1746487 - [HCM] Focus indicator is not visible

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Morgan Reschenberg [:morgan]]

Attachment: Focus on 'show all downloads' HCM white

STR:

0. Enable Windows HCM
1. Open (improved) downloads panel
2. Using tab or arrow keys, move through the list of downloads

Expected:
Each item gets focus, including the "show all downloads" option at the end of the panel

Actual:
Only the "show all downloads" option gets focus

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Focus on 'show all downloads' HCM black

Comment 2

[Molly Howell (she/her) (mostly inactive)]

It seems like we just don't have focus rings anywhere on those list items, ever, at all. Gijs, do you have a sense of what I'd be getting myself into if I wanted to fix that?

Comment 3

[:Gijs (he/him)]

(In reply to Molly Howell (she/her) [:mhowell] from comment #2)

It seems like we just don't have focus rings anywhere on those list items, ever, at all. Gijs, do you have a sense of what I'd be getting myself into if I wanted to fix that?

It should be OK (famous last words) ? I would expect that we'd use the same outline style we use for the footer item, and the tab order should go list item -> its detail button -> next list item -> its detail button, etc. That might take some work and/or have some correlation with the work Neil is doing in bug 1742530...

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Turns out this is getting fixed by the patch in bug 1742530; what's happening is that the selector for the focused item in this panel is subtly broken, so it never matches and we're never drawing any kind of focus indicator. Thanks to Neil for pointing that out to me.

[this is not strictly a duplicate of 1742530, but I'm marking it as such so that its state is sort of tied to that one]