1746595 - Throw unknown command error when calling an unexpected bidi command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1731576#c15

(In reply to James Graham [:jgraham] from Bug 1731576 comment #15)

From a spec perspective this will respond with an unknown command error, see https://w3c.github.io/webdriver-bidi/#handle-an-incoming-message.

I think we want to be able to write tests that check that we handle unknown commands correctly without always having logspam, so it might make sense to change the way we log in this case.

Right now, when an unsupported command is called, the message handler will throw an internal error "UnsupportedCommandError" https://searchfox.org/mozilla-central/rev/5e15e00fa247cba5b765727496619bf9010ed162/remote/shared/messagehandler/Errors.jsm#72

We should translate this to a webdriver error "UnknownCommandError" https://searchfox.org/mozilla-central/rev/5e15e00fa247cba5b765727496619bf9010ed162/remote/shared/webdriver/Errors.jsm#497

This can probably be handled in webdriver/Session.jsm https://searchfox.org/mozilla-central/rev/5e15e00fa247cba5b765727496619bf9010ed162/remote/shared/webdriver/Session.jsm#223

wdspec tests should be added to check that we throw the expected error.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

For reference here is what we do in Marionette:
https://searchfox.org/mozilla-central/rev/5e15e00fa247cba5b765727496619bf9010ed162/remote/marionette/server.js#296-300

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1746595 - [bidi] Throw unknown command error when calling an unexpected bidi command adn Summary:

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1746595 - [wdspec] Add wdspec tests for unknown command error

Depends on D134247

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ffa849a6d2
[bidi] Throw unknown command error when calling an unexpected bidi command adn Summary: r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/37149f29af6d
[wdspec] Add wdspec tests for unknown command error r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32145 for changes under testing/web-platform/tests

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/77ffa849a6d2
https://hg.mozilla.org/mozilla-central/rev/37149f29af6d

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot