1746695 - Improve method and variable names related to charset detection, fix comments, fix passing detected charset to the UI

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Rachel Martin]

+++ This bug was initially created as a clone of Bug #1713786 +++

In bug 1713786 manually setting a charset was replaced with charset detection. We feel that the method and variable names should be improved in this area. Also, there are still some comments referring to the "folder charset" that was removed in bug 1671880 part 2.

Previously, it was all about overriding the message charset. Now it is about first auto-detecting a suitable message charset and then overriding the message charset with the auto-detected one. Overriding uses a flag and a charset, auto-detection just uses a flag. We hope that our patch clarifies the concepts.

In a second part we fix a bug that causes the detected charset not being reflected in msgWindow.mailCharacterSet as can be seen with the CharsetMenu add-on.

Comment 1

[Rachel Martin]

Attachment: Part 1: 1746695-charset-detect.patch

No functional change here, just renaming methods and variables and fixing comments.

Comment 2

[Rachel Martin]

Attachment: Part 1: 1746695-charset-detect.patch

s/CharSet/Charset/ for consistent spelling.

Comment 3

[Rachel Martin]

Attachment: Russian-test-message.eml

Test message for Part 2. The message has no charset, but is displayed correctly. However, dumping out msgWindow.mailCharacterSet in the console shows UTF-8, which is not correct.

Comment 4

[Rachel Martin]

Attachment: Part 2: 1746695-charset-detect-UI.patch

You can use console.log(msgWindow.mailCharacterSet) to check the patch. It will now display KOI8-U which is the detected charset.

Note that the subject isn't displayed correctly, that's bug 1739609.

Comment 5

[Rachel Martin]

(In reply to Rachel Martin from comment #4)

Note that the subject isn't displayed correctly, that's bug 1739609.

More precisely: The subject is also in KOI8-U, so of course it's not displayed correctly. Bug 1739609 should likely fix that.

Comment 6

[Rachel Martin]

Attachment: Part 2: 1746695-charset-detect-UI.patch

Added a test.

Comment 7

[Rachel Martin]

Attachment: Part 2: 1746695-charset-detect-UI.patch

There was potential to improve the existing test.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9255991 [details] [diff] [review]
Part 1: 1746695-charset-detect.patch

Review of attachment 9255991 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=mkmelin

Comment 9

[Rachel Martin]

Thank you.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/778b87646604
Improve method and variable names related to charset detection. r=mkmelin
https://hg.mozilla.org/comm-central/rev/00ae85f77818
Fix communication of charset back to window. r=mkmelin