1746833 - Implement textual value for cached RemoteAccessibles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

In bug 1727643, we implemented support for numeric values in the cache. We also need to support textual values; i.e. those returned by LocalAccessible::Value. These are needed for <select> controls and numeric value controls which use aria-valuetext. We're also supposed to support textual value for ARIA combo boxes, but we don't fully support that yet; see bug 1631693, bug 1732284. (I think we should still try to cache for ARIA combo boxes, though, as there are cases which do work and the ones that don't will start working once LocalAccessible is fixed.)

Even though <input> and <textarea> text boxes expose a textual value, we probably don't want to cache this, as we can derive that from the text. These should be the exception, though. So, I'm thinking it'll be easier to cache Value in all cases except for <input> text and <textarea>.

I think we'll need this for Android, so marking as ctw-m1.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1746833 - P1: Push text value to cache. r?Jamie

Only push it in certain instances, and calculate it in others.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1746833 - P2: Move Value() to Accessible and calculate or use cached value remotely. r?Jamie

Depends on D138947

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1746833 - P3: Make GetTextEquivFromSubtree take Accessible. r?Jamie

The previous patch moved Value to Accessible. We can now use it in
GetTextEquivFromSubtree.

Depends on D138948

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1746833 - P4: Add remote textbox value calculation and tests. r?Jamie

Depends on D138949

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe8db552446d
P1: Push text value to cache. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/ed7b9895c523
P2: Move Value() to Accessible and calculate or use cached value remotely. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/e09eb9b46d1c
P3: Make GetTextEquivFromSubtree take Accessible. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/ec8a133b9497
P4: Add remote textbox value calculation and tests. r=Jamie

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fe8db552446d
https://hg.mozilla.org/mozilla-central/rev/ed7b9895c523
https://hg.mozilla.org/mozilla-central/rev/e09eb9b46d1c
https://hg.mozilla.org/mozilla-central/rev/ec8a133b9497