Index the DumperError annotation
Categories
(Socorro :: General, task, P2)
Tracking
(Not tracked)
People
(Reporter: gsvelto, Assigned: willkg)
References
Details
Attachments
(1 file)
In bug 1666733 we added a new annotation (DumperError
) to record failures to write a minidump. This field is currently not indexed so it would be nice for it to be. The field is currently not public and for the time being I think it should stay that way because it's a formatted string (see this list of errors). Once we know what appears in the wild we might want to make it public but only after having sanitized it like we do for raw crash reasons.
Assignee | ||
Comment 1•3 years ago
|
||
I skimmed the related bugs, but didn't see a data review. Is there one?
Reporter | ||
Comment 2•3 years ago
|
||
Probably not, I don't remember when I was first told new annotations needed a data review so a few slipped in between when the new policy was put in place and when we started applying it consistently. Should I ask for a retroactive data-review?
Assignee | ||
Comment 3•3 years ago
|
||
Yes, please.
At some point (hopefully soon?), I'm planning to go through the crash annotations we're getting and collect metadata for them about what we're collecting, the value domain, why we're collecting it, code, related data reviews, etc similar to what we're doing with data in Telemetry. Then we can make that data easier to search, use, understand for everyone.
Reporter | ||
Comment 4•3 years ago
|
||
I've put the data review request in bug 1666733 comment 5.
Assignee | ||
Comment 5•3 years ago
|
||
Grabbing to do next year.
Assignee | ||
Comment 6•3 years ago
|
||
(The new "crash report keys" field is amazing... Yay!)
I looked at some values and they look like unstructured sentences. I think we want to index this like strings rather than like keywords. Then you can do substring searches.
Assignee | ||
Comment 7•3 years ago
|
||
Assignee | ||
Comment 8•3 years ago
|
||
willkg merged PR #5969: "bug 1746850: add DumperError to search" in c116de4.
This will let use queries like:
dumper_error exists
/dumper_error does not exist
dumper_error has terms "somestring"
for case-insensitive, analyzed substring searches
Assignee | ||
Comment 9•3 years ago
|
||
This was deployed earlier today in bug #1749582.
We'll need to wait until the weekend for a new index to get created. I'll keep this open and verify then.
Assignee | ||
Comment 10•3 years ago
|
||
New index was created and this field works nicely in search. Marking as FIXED.
Reporter | ||
Comment 11•3 years ago
|
||
Woohoo! This is going to be super-useful
Description
•