1746852 - user scripts aren't unregistered when context is getting closed

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[William Durand [:willdurand]]

We call unregisterContentScripts() when the context is getting closed here: https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-userScripts.js#95-99 but the problem is that registeredScriptIds is an empty set because we don't add any scriptId when we register a user script (in userScripts.register() a few lines below).

We should add the scriptId of a newly registered user script to the registeredScriptIds set so that we unregister all of them when the context is being closed.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1746852 - Add `scriptId` to `registeredScriptIds` to be able to unregister all user scripts when context is being closed. r?rpl!

We register a function that is called when the context is getting closed
but this function relies on a set of script IDs that is always empty,
because we don't add any IDs to it when we register a user script. This
patch adds script IDs of registered user scripts to this set.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5eb78be7a83c
Add `scriptId` to `registeredScriptIds` to be able to unregister all user scripts when context is being closed. r=rpl

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5eb78be7a83c