1746917 - Clean up locking in MediaTrackGraph

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

MediaTrackGraph doesn't take locks when accessing some members for debug messages or assertions. Not an issue in the field normally, but good to clean up and lets us do static analysis of locking

Also, one member is accessed for deciding an early return without locking.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1746917: MediaTrackGraph cleanup r=padenot

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Landed: https://hg.mozilla.org/integration/autoland/rev/68d37cc2dbf3b411bef44d8eaf5a2cb3bc2772d5

Backed out for build bustage in MediaTrackGraph.h:

https://hg.mozilla.org/integration/autoland/rev/94b76fa487b3c0db8ac6aa2048f70b39de7e1c32

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=To06SJmcT6mdC5f3cuoZEQ.0&resultStatus=retry%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel&revision=68d37cc2dbf3b411bef44d8eaf5a2cb3bc2772d5
Failure log: https://treeherder.mozilla.org/logviewer?job_id=362893778&repo=autoland

[task 2022-01-03T15:16:59.519Z] 15:16:59    ERROR -  /builds/worker/workspace/obj-build/dist/include/MediaTrackGraph.h:704:20: error: expected ';' at end of declaration list
[task 2022-01-03T15:16:59.519Z] 15:16:59     INFO -    Mutex& GetMutex() RETURN_CAPABILITY(mMutex) { return mMutex; }
[task 2022-01-03T15:16:59.519Z] 15:16:59     INFO -                     ^
[task 2022-01-03T15:16:59.520Z] 15:16:59     INFO -                     ;

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

MediaTrackGraph cleanup r=padenot
https://hg.mozilla.org/integration/autoland/rev/669d85b972c357746e9c2d2a04a3e9b6359b753e
https://hg.mozilla.org/mozilla-central/rev/669d85b972c3