Closed Bug 1747027 Opened 4 years ago Closed 19 days ago

[meta] Add alignment swatch widgets to the ruleview

Categories

(DevTools :: Inspector, task, P3)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1492056

People

(Reporter: jdescottes, Unassigned)

Details

(Keywords: meta)

Attachments

(3 files)

Chromium and Safari now have widgets to help users pick align-content values.

We should reuse our current setup with Swatch + Tooltip (https://searchfox.org/mozilla-central/source/devtools/client/shared/widgets/tooltip/SwatchBasedEditorTooltip.js) and offer similar features.

Filing as a meta if we end up splitting this over various properties.

Attached image image.png —

Here is an example from Safari.

Victoria: Hi! Do you remember if there were existing bugs or documents to bring this to the Rule View?

Flags: needinfo?(victoria)
Attached image image.png —

Awesome! My mockups for a similar feature, autocomplete menu icons, live here and I've attached them.

Probably makes sense to follow their lead on the differences, except that I think my icon style may be a bit more legible because it's two-tone.

Flags: needinfo?(victoria)
Attached image chrome —

Actually I think chromium's icons are better than mine despite being monochrome. They had a great idea with using round rects for the items.

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:jdescottes, maybe it's time to close this bug?

Flags: needinfo?(jdescottes)

Nicolas, we might file individual bugs soon-ish to track this work? Do you have any filed already?

Flags: needinfo?(jdescottes) → needinfo?(nchevobbe)

(In reply to Julian Descottes [:jdescottes] from comment #5)

Nicolas, we might file individual bugs soon-ish to track this work? Do you have any filed already?

Nothing yet, I'll probably file some when we start working on this

Flags: needinfo?(nchevobbe)

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:jdescottes, maybe it's time to close this bug?

Flags: needinfo?(jdescottes)

Yes this would still make sense to implement.

Flags: needinfo?(jdescottes)

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:jdescottes, maybe it's time to close this bug?

Flags: needinfo?(jdescottes)

Yes this would still make sense to implement.

Flags: needinfo?(jdescottes)
Priority: -- → P3

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:nchevobbe, maybe it's time to close this bug?

Flags: needinfo?(nchevobbe)

I think we can mark as duplicate of Bug 1492056, which has the same goal (and has an attached WIP patch)

Status: NEW → RESOLVED
Closed: 19 days ago
Duplicate of bug: 1492056
Flags: needinfo?(nchevobbe)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: