Closed Bug 1747162 Opened 2 years ago Closed 2 years ago

Intermittent browser/base/content/test/general/browser_documentnavigation.js | back focus with downloads panel open element matches (wanted: got: downloadsHistory) - Got [object XULElement], expected [object XULFrameElement]

Categories

(Firefox :: General, defect, P5)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox95 --- unaffected
firefox96 --- unaffected
firefox97 --- fixed
firefox98 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kpatenio)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered][stockwell unknown])

Attachments

(2 files)

potential_intermittence_cause.mov
4.04 MB, video/quicktime
Details
Bug 1747162 - reduce intermittence of browser_documentnavigation.js. r=gijs!
48 bytes, text/x-phabricator-request
Details | Review

Filed by: ccozmuta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=362067295&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HzIITjo7TNqsjk0NvoaLUA/runs/1/artifacts/public/logs/live_backing.log

[task 2021-12-21T22:54:34.356Z] 22:54:34     INFO - TEST-START | browser/base/content/test/general/browser_documentnavigation.js
[task 2021-12-21T22:54:34.384Z] 22:54:34     INFO - GECKO(2695) | [Parent 2695, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x804B0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS): file /builds/worker/checkouts/gecko/toolkit/components/antitracking/URLQueryStringStripper.cpp:129
[task 2021-12-21T22:54:34.387Z] 22:54:34     INFO - GECKO(2695) | [Child 2770, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x804B0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS): file /builds/worker/checkouts/gecko/toolkit/components/antitracking/URLQueryStringStripper.cpp:129
[task 2021-12-21T22:54:34.420Z] 22:54:34     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (7f0291b0c800) [pid = 2891] [serial = 159] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.420Z] 22:54:34     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (7f0298644c00) [pid = 2891] [serial = 155] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.422Z] 22:54:34     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (7f0291b07800) [pid = 2891] [serial = 157] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.423Z] 22:54:34     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f0291b0bc00 == 2 [pid = 2891] [id = 62] [url = about:blank]
[task 2021-12-21T22:54:34.424Z] 22:54:34     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f0291b09000 == 1 [pid = 2891] [id = 63] [url = about:blank]
[task 2021-12-21T22:54:34.457Z] 22:54:34     INFO - GECKO(2695) | [Child 2770: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (7f71256bf000) [pid = 2770] [serial = 161] [outer = 7f7126ca1200]
[task 2021-12-21T22:54:34.619Z] 22:54:34     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (7f0291585740) [pid = 2891] [serial = 158] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.621Z] 22:54:34     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7f0291585040) [pid = 2891] [serial = 161] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.675Z] 22:54:34     INFO - GECKO(2695) | [Child 2913: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7f40322da400) [pid = 2913] [serial = 128] [outer = 0] [url = data:text/html,<p><a id="commonlink" href="http://mochi.test/moz/">Common link</a></p><p><math id="mathlink" xmlns="http://www.w3.org/1998/Math/MathML" href="http://mochi.test/moz/"><mtext>MathML XLink</mtext></math></p><p><svg id="svgxlink" xmlns="http://www.w3.org/2000/svg" width="100px" height="50px" version="1.1"><a xlink:type="simple" xlink:href="http://mochi.test/moz/"><text transform="translate(10, 25)">SVG XLink</text></a></svg></p><br><span id="host"></span><script>document.getElementById("host").attachShadow({mode: "closed"}).appendChild(document.getElementById("commonlink").cloneNode(true));</script><iframe id="frame" src="https://test2.example.com:443/browser/browser/base/content/test/general/file_with_link_to_http.html"></iframe>]
[task 2021-12-21T22:54:34.675Z] 22:54:34     INFO - GECKO(2695) | [Child 2913: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7f40322de000) [pid = 2913] [serial = 130] [outer = 0] [url = https://test2.example.com/browser/browser/base/content/test/general/file_with_link_to_http.html]
[task 2021-12-21T22:54:34.675Z] 22:54:34     INFO - GECKO(2695) | [Child 2913: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7f4032b03800) [pid = 2913] [serial = 132] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.675Z] 22:54:34     INFO - GECKO(2695) | [Child 2913: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7f40322d3400) [pid = 2913] [serial = 127] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.675Z] 22:54:34     INFO - GECKO(2695) | [Child 2913: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f40322de800 == 0 [pid = 2913] [id = 45] [url = about:blank]
[task 2021-12-21T22:54:34.736Z] 22:54:34     INFO - GECKO(2695) | [Child 2913: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7f4032ba1ac0) [pid = 2913] [serial = 131] [outer = 0] [url = about:blank]
[task 2021-12-21T22:54:34.864Z] 22:54:34     INFO - GECKO(2695) | [Parent 2695, Main Thread] WARNING: '!IsSelectionValid()', file /builds/worker/checkouts/gecko/widget/ContentCache.cpp:667
[task 2021-12-21T22:54:34.864Z] 22:54:34     INFO - GECKO(2695) | [Parent 2695, Main Thread] WARNING: '!mContentCache.HandleQueryContentEvent( aEvent, textInputHandlingWidget)', file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3052
[task 2021-12-21T22:54:35.129Z] 22:54:35     INFO - GECKO(2695) | [Parent 2695, Main Thread] WARNING: '!IsSelectionValid()', file /builds/worker/checkouts/gecko/widget/ContentCache.cpp:667
[task 2021-12-21T22:54:35.130Z] 22:54:35     INFO - GECKO(2695) | [Parent 2695, Main Thread] WARNING: '!mContentCache.HandleQueryContentEvent( aEvent, textInputHandlingWidget)', file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3052
[task 2021-12-21T22:54:35.331Z] 22:54:35     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f0291b07800 == 2 [pid = 2891] [id = 65]
[task 2021-12-21T22:54:35.332Z] 22:54:35     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (7f0291585040) [pid = 2891] [serial = 166] [outer = 0]
[task 2021-12-21T22:54:35.332Z] 22:54:35     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (7f0291b07c00) [pid = 2891] [serial = 167] [outer = 7f0291585040]
<...>
[task 2021-12-21T22:54:39.254Z] 22:54:39     INFO - Leaving test bound 
[task 2021-12-21T22:54:39.254Z] 22:54:39     INFO - Entering test bound test_download_focus
[task 2021-12-21T22:54:39.255Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with downloads panel open panel document matches - 
[task 2021-12-21T22:54:39.256Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with downloads panel open panel element matches (wanted: downloadsHistory got: downloadsHistory) - 
[task 2021-12-21T22:54:39.256Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | expected element html1 was found - 
[task 2021-12-21T22:54:39.257Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with downloads panel open child focus matches - 
[task 2021-12-21T22:54:39.258Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with downloads panel open document matches - 
[task 2021-12-21T22:54:39.259Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with downloads panel open element matches (wanted:  got: ) - 
[task 2021-12-21T22:54:39.259Z] 22:54:39     INFO - Buffered messages logged at 22:54:38
[task 2021-12-21T22:54:39.260Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus downloads panel open urlbar document matches - 
[task 2021-12-21T22:54:39.261Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus downloads panel open urlbar element matches (wanted: urlbar-input got: urlbar-input) - 
[task 2021-12-21T22:54:39.261Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | expected element html1 was found - 
[task 2021-12-21T22:54:39.262Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with downloads panel open child focus matches - 
[task 2021-12-21T22:54:39.263Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with downloads panel open document matches - 
[task 2021-12-21T22:54:39.263Z] 22:54:39     INFO - Buffered messages finished
[task 2021-12-21T22:54:39.265Z] 22:54:39     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_documentnavigation.js | back focus with downloads panel open element matches (wanted:  got: downloadsHistory) - Got [object XULElement], expected [object XULFrameElement]
[task 2021-12-21T22:54:39.265Z] 22:54:39     INFO - Stack trace:
[task 2021-12-21T22:54:39.265Z] 22:54:39     INFO - chrome://mochikit/content/browser-test.js:test_is:1403
[task 2021-12-21T22:54:39.265Z] 22:54:39     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_documentnavigation.js:expectFocusOnF6:106
[task 2021-12-21T22:54:39.266Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with downloads panel open document matches - 
[task 2021-12-21T22:54:39.267Z] 22:54:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-12-21T22:54:39.268Z] 22:54:39     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_documentnavigation.js | back focus with downloads panel open element matches (wanted: downloadsHistory got: urlbar-input) - Got [object HTMLInputElement], expected [object XULElement]
[task 2021-12-21T22:54:39.268Z] 22:54:39     INFO - Stack trace:
[task 2021-12-21T22:54:39.268Z] 22:54:39     INFO - chrome://mochikit/content/browser-test.js:test_is:1403
[task 2021-12-21T22:54:39.268Z] 22:54:39     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_documentnavigation.js:expectFocusOnF6:106
[task 2021-12-21T22:54:39.269Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus downloads panel open urlbar document matches - 
[task 2021-12-21T22:54:39.270Z] 22:54:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-12-21T22:54:39.271Z] 22:54:39     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_documentnavigation.js | back focus downloads panel open urlbar element matches (wanted: urlbar-input got: ) - Got [object XULFrameElement], expected [object HTMLInputElement]
[task 2021-12-21T22:54:39.271Z] 22:54:39     INFO - Stack trace:
[task 2021-12-21T22:54:39.271Z] 22:54:39     INFO - chrome://mochikit/content/browser-test.js:test_is:1403
[task 2021-12-21T22:54:39.271Z] 22:54:39     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_documentnavigation.js:expectFocusOnF6:106
[task 2021-12-21T22:54:39.272Z] 22:54:39     INFO - Leaving test bound test_download_focus
[task 2021-12-21T22:54:39.272Z] 22:54:39     INFO - Entering test bound 
[task 2021-12-21T22:54:39.273Z] 22:54:39     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f0291b07400 == 1 [pid = 2891] [id = 66]
[task 2021-12-21T22:54:39.274Z] 22:54:39     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7f0291585040) [pid = 2891] [serial = 169] [outer = 0]
[task 2021-12-21T22:54:39.275Z] 22:54:39     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7f0291b07800) [pid = 2891] [serial = 170] [outer = 7f0291585040]
[task 2021-12-21T22:54:39.276Z] 22:54:39     INFO - GECKO(2695) | [Parent 2695, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x804B0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS): file /builds/worker/checkouts/gecko/toolkit/components/antitracking/URLQueryStringStripper.cpp:129
[task 2021-12-21T22:54:39.277Z] 22:54:39     INFO - GECKO(2695) | [Child 2891, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x804B0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS): file /builds/worker/checkouts/gecko/toolkit/components/antitracking/URLQueryStringStripper.cpp:129
[task 2021-12-21T22:54:39.292Z] 22:54:39     INFO - GECKO(2695) | [Child 2891: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (7f0291b06c00) [pid = 2891] [serial = 171] [outer = 7f0291585040]
[task 2021-12-21T22:54:39.312Z] 22:54:39     INFO - GECKO(2695) | [Child 2891, Main Thread] WARNING: '!aChild->IsContent()', file /builds/worker/workspace/obj-build/dist/include/mozilla/EditorDOMPoint.h:525
[task 2021-12-21T22:54:39.416Z] 22:54:39     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "data:text/html,<html id='html3'><body id='body3' contenteditable='true'><button id='button3'>Tab 3</button></body></html>" line: 0}]
[task 2021-12-21T22:54:39.477Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | expected element body3 was found - 
[task 2021-12-21T22:54:39.642Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with contenteditable body child focus matches - 
[task 2021-12-21T22:54:39.643Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with contenteditable body document matches - 
[task 2021-12-21T22:54:39.646Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with contenteditable body element matches (wanted:  got: ) - 
[task 2021-12-21T22:54:39.673Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with contenteditable body urlbar document matches - 
[task 2021-12-21T22:54:39.674Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | focus with contenteditable body urlbar element matches (wanted: urlbar-input got: urlbar-input) - 
[task 2021-12-21T22:54:39.681Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | expected element body3 was found - 
[task 2021-12-21T22:54:39.796Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with contenteditable body child focus matches - 
[task 2021-12-21T22:54:39.797Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with contenteditable body document matches - 
[task 2021-12-21T22:54:39.798Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with contenteditable body element matches (wanted:  got: ) - 
[task 2021-12-21T22:54:39.836Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with contenteditable body urlbar document matches - 
[task 2021-12-21T22:54:39.837Z] 22:54:39     INFO - TEST-PASS | browser/base/content/test/general/browser_documentnavigation.js | back focus with contenteditable body urlbar element matches (wanted: urlbar-input got: urlbar-input) - 
[task 2021-12-21T22:54:39.897Z] 22:54:39     INFO - Leaving test bound

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Address Bar
Component: Address Bar → General
See Also: → 1747227

Backfills and retriggers indicate bug 1743226 is the culprit

Regressed by: 1743226
Has Regression Range: --- → yes
Keywords: regression
Flags: needinfo?(kpatenio)
Whiteboard: [retriggered][stockwell needswork:owner]

Will look into this

Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Flags: needinfo?(kpatenio)

Error occurs when we open the downloads panel.
I wonder if this could be ameliorated if we wait some time after the download panel is shown (before this probably), rather than testing assertions right away.

Update: hmmm actually, if downloads panel is manually opened by selecting the download button, then setting or modifying the delay might make no difference here

Will need a second pair of eyes for this. @gijs am I missing something or overthinking this?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to kpatenio from comment #9)

Will need a second pair of eyes for this. @gijs am I missing something or overthinking this?

When looking at intermittent failures I try to start with understanding why it's failing. And I'm coming up short here because I'm struggling to reproduce this locally ( bug 1748829 ), and the logs are not much help. The "wrong" thing is being focused - but what is the thing that is being focused, instead of the downloads richlistbox? The logs just say "XULElement", and it apparently doesn't have an id...

I'm hoping you can reproduce this locally. Otherwise, the next best thing would be to push to try with more logging to work out what's wrong. It'd be useful to have better logging in the test (maybe log the outerHTML of the element being focused?) and/or to have logging from the code added in bug 1743226 to see if your expectations about whether we're delaying enabling/disabling things are correct.

If I had to guess about what's wrong, I would say that AFAICT the test is opening the downloads panel without it having any download items in it. What is the focus behaviour in that case? The rich list box is empty, right? So what do we focus, and did that perhaps change?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(kpatenio)

(In reply to :Gijs (he/him) from comment #10)

(In reply to kpatenio from comment #9)

Will need a second pair of eyes for this. @gijs am I missing something or overthinking this?

When looking at intermittent failures I try to start with understanding why it's failing. And I'm coming up short here because I'm struggling to reproduce this locally ( bug 1748829 ), and the logs are not much help. The "wrong" thing is being focused - but what is the thing that is being focused, instead of the downloads richlistbox? The logs just say "XULElement", and it apparently doesn't have an id...

I'm hoping you can reproduce this locally. Otherwise, the next best thing would be to push to try with more logging to work out what's wrong. It'd be useful to have better logging in the test (maybe log the outerHTML of the element being focused?) and/or to have logging from the code added in bug 1743226 to see if your expectations about whether we're delaying enabling/disabling things are correct.

If I had to guess about what's wrong, I would say that AFAICT the test is opening the downloads panel without it having any download items in it. What is the focus behaviour in that case? The rich list box is empty, right? So what do we focus, and did that perhaps change?

Thanks Gijs. Had a second go at this. F6 focusing behaviour seems to act differently for each OS, depending on whether or not the download panel is empty. (Tested this manually with the latest versions of Nightly). With linux and windows 10, it seems to act as the tests expects if the panel is empty. With MacOS, I can't focus on the panel if empty. With items downloaded, it is not immediately obvious what is focused for all OS'es, so I will need to do more logging there.

I realized recently that we never actually verified what happens if the downloads panel is empty in our written test. By updating the test, I hope to see if issues arise (if so, this will most likely explain why browser_documentnavigation.js fails intermittently).

Also somewhat related to bug 1747465: it appears I forgot to take into account onViewLoadCompleted(). It calls this._openPopupIfDataReady(), however without a openedManually parameter. Thus, this may explain why openedManually is initially set to undefined before updating to an appropriate true or false boolean. Furthermore, that could cause flakey results with the falsy condition set up in downloads.js.

Flags: needinfo?(kpatenio)
See Also: → 1747465

Could not reproduce reliably locally or with try pushes (especially with MacOS... since I could not focus on #downloadsHistory). So instead, I opted for another solution: removing the !openedManually condition and testing this change locally on Ubuntu. Made a try push with this change and also recorded how it behaves.

Given the following conditions:

  1. downloads panel is empty
  2. delay timer ends (in the video, security.dialog_enable_delay is set to 5 seconds)

... I'm suspecting that we end up focusing on the #downloadsHistory button. In browser_documentnavigation.js, we are supposed to be focused on the url bar. And, from there, we navigate backwards to the page's content using shift+F6. Before that can happen, the delay timer passes and we end up focusing on the downloads panel instead, messing up the order of focus.

I can think of two potential fixes:

  1. addressing flaky situation we found with bug 1747465
  2. and/or simply setting security.dialog_enable_delay to 0 in the test browser_documentnavigation.js

(In reply to kpatenio from comment #13)

I can think of two potential fixes:

  1. addressing flaky situation we found with bug 1747465
  2. and/or simply setting security.dialog_enable_delay to 0 in the test browser_documentnavigation.js

Given the frequency of this failure let's start by fixing (2) and fix (1) in bug 1747465. Thanks for investigating this!

Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbf92c7b809f
reduce intermittence of browser_documentnavigation.js. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/bbf92c7b809f

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: