1747250 - Downloads panel context menu => make "Open in System Viewer" menuitem label dynamic, so it says "Open in Photos" or "Open in NotePad"

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, enhancement)

Description

[Shane Hughes [:aminomancer]]

The unknown content type dialog shows the names and icons for the system handlers. Idk how slow that is, but I never used the "Open in System Viewer" menuitem at all until like a month or two ago when I heard about the improvements_to_download_panel changes. I didn't understand what the menuitem would do, didn't wanna click something unknown and have something unpredictable happen. The label is hard to decipher, and I can't think of any universal phrasing that would be any clearer. It would just be vastly better if that menuitem told you exactly what's gonna happen when you click it.

So I am proposing that the menupopup's popupshowing handler ascertains the name of the handler that will be invoked by downloadsCmd_openInSystemViewer, e.g., when clicking the menuitem that is now labeled "Open in System Viewer." The translation can be changed to Open in { $name } and the name of the handler passed as an argument. The name of the handler can be derived the same way as in the helper dialog. I don't know if MIMEInfo.defaultDescription always returns the same handler that will ultimately be invoked when clicking the menuitem though.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1747250 - Show the actual System Viewer name in downloads panel context menu item labels. r?#fluent-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ab88029532a
Show the actual System Viewer name in downloads panel context menu item labels. r=fluent-reviewers,mak,flod

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5ab88029532a