1747269 - Permafailing [Sym] OverflowError: string longer than 2147483647 bytes

Status: VERIFIED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Natalia Csoregi [:nataliaCs]]

• Central-as-beta
• How to run these simulations
• Failure log

[task 2021-12-22T14:07:07.035Z] INFO:upload-symbols:Attempt 1 of 7...
[task 2021-12-22T14:07:08.974Z] Traceback (most recent call last):
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/toolkit/crashreporter/tools/upload_symbols.py", line 260, in <module>
[task 2021-12-22T14:07:08.974Z]     sys.exit(main())
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/toolkit/crashreporter/tools/upload_symbols.py", line 229, in main
[task 2021-12-22T14:07:08.974Z]     r = requests.post(
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/api.py", line 119, in post
[task 2021-12-22T14:07:08.974Z]     return request('post', url, data=data, json=json, **kwargs)
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/api.py", line 61, in request
[task 2021-12-22T14:07:08.974Z]     return session.request(method=method, url=url, **kwargs)
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/sessions.py", line 542, in request
[task 2021-12-22T14:07:08.974Z]     resp = self.send(prep, **send_kwargs)
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/sessions.py", line 655, in send
[task 2021-12-22T14:07:08.974Z]     r = adapter.send(request, **kwargs)
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/adapters.py", line 439, in send
[task 2021-12-22T14:07:08.974Z]     resp = conn.urlopen(
[task 2021-12-22T14:07:08.974Z]   File "/builds/worker/checkouts/gecko/third_party/python/urllib3/urllib3/connectionpool.py", line 670, in urlopen
[task 2021-12-22T14:07:08.975Z]     httplib_response = self._make_request(
[task 2021-12-22T14:07:08.975Z]   File "/builds/worker/checkouts/gecko/third_party/python/urllib3/urllib3/connectionpool.py", line 392, in _make_request
[task 2021-12-22T14:07:08.975Z]     conn.request(method, url, **httplib_request_kw)
[task 2021-12-22T14:07:08.975Z]   File "/usr/lib/python3.9/http/client.py", line 1255, in request
[task 2021-12-22T14:07:08.975Z]     self._send_request(method, url, body, headers, encode_chunked)
[task 2021-12-22T14:07:08.975Z]   File "/usr/lib/python3.9/http/client.py", line 1301, in _send_request
[task 2021-12-22T14:07:08.975Z]     self.endheaders(body, encode_chunked=encode_chunked)
[task 2021-12-22T14:07:08.975Z]   File "/usr/lib/python3.9/http/client.py", line 1250, in endheaders
[task 2021-12-22T14:07:08.975Z]     self._send_output(message_body, encode_chunked=encode_chunked)
[task 2021-12-22T14:07:08.975Z]   File "/usr/lib/python3.9/http/client.py", line 1049, in _send_output
[task 2021-12-22T14:07:08.975Z]     self.send(chunk)
[task 2021-12-22T14:07:08.975Z]   File "/usr/lib/python3.9/http/client.py", line 971, in send
[task 2021-12-22T14:07:08.975Z]     self.sock.sendall(data)
[task 2021-12-22T14:07:08.975Z]   File "/usr/lib/python3.9/ssl.py", line 1204, in sendall
[task 2021-12-22T14:07:08.976Z]     v = self.send(byte_view[count:])
[task 2021-12-22T14:07:08.976Z]   File "/usr/lib/python3.9/ssl.py", line 1173, in send
[task 2021-12-22T14:07:08.976Z]     return self._sslobj.write(data)
[task 2021-12-22T14:07:08.976Z] OverflowError: string longer than 2147483647 bytes
[task 2021-12-22T14:07:09.581Z] Creating default state directory: /builds/worker/.mozbuild
[taskcluster 2021-12-22 14:07:09.987Z] === Task Finished ===
[taskcluster 2021-12-22 14:07:09.987Z] Unsuccessful task run with exit code: 1 completed in 422.572 seconds

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1739321 doubled the size of the full symbols file, central-as-beta simulations fail first because they have ~200 MB more symbols.

Comment 2

[Steve Fink [:sfink] [:s:]]

Ok, this is exactly what I was worried about.

I think we'll probably need to restrict the flag to js/src/**, or perhaps even a subset thereof.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1747269 - Emit debuginfo for all type symbols for js/src/**

Comment 4

[Norisz Fay [:noriszfay]]

Hi, the patch is not working, sym bustages still appear on latest beta-sim

Comment 5

[Steve Fink [:sfink] [:s:]]

(In reply to Norisz Fay [:noriszfay] from comment #4)

Hi, the patch is not working, sym bustages still appear on latest beta-sim

You need to backout 3c69c388216d0f7ef7e13722f3cfb3bf215cffea from bug 1739321 for this to do anything.

Comment 6

[Steve Fink [:sfink] [:s:]]

I'm having bug 1739321 backed out and this one pushed. I would be interested in seeing the difference in the size of the full symbol file. We may want to make this even more targeted to the subdirectories containing symbols that we're losing with clang 13.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81ba910d0a59
Emit debuginfo for all type symbols for js/src/** . CLOSED TREE

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/81ba910d0a59

Comment 9

[Alexandru Michis [:malexandru]]

Verified fixed in today's central as early beta simulation.