1747310 - CID 1495417: move assignment operator for DataBuffer

Status: RESOLVED FIXED

(NSS :: Test, enhancement, P5)

Description

[Martin Thomson [:mt:]]

Adding a default value will make some of the assignments cheaper and faster. It will also silence some coverity warnings.

Comment 1

[Martin Thomson [:mt:]]

Attachment: Bug 1747310 - move assignment operator for DataBuffer r=#nss-reviewers

Comment 2

[Benjamin Beurdouche [:beurdouche]]

This apparently wasn't run through the CI before landing and seems to break gtest.
https://treeherder.mozilla.org/jobs?repo=nss-try&revision=c66ce0bf4eded5ed30b00f6dd8798dd0fd56bb5

Comment 3

[Martin Thomson [:mt:]]

Attachment: Bug 1747310 - real move assignment operator, r=#nss-reviewers

Comment 4

[Martin Thomson [:mt:]]

Thanks for catching that. It's a simple enough fix.

I should run ASAN builds locally, but I don't because they take far too long thanks to the PSS tests. 15 minutes is not something I usually have patience for. I'll have to do something about that.

Comment 5

[Benjamin Beurdouche [:beurdouche]]

https://hg.mozilla.org/projects/nss/rev/6a6731d4e0a38a4e42060597061606e864aa107d
https://hg.mozilla.org/projects/nss/rev/2902346fab195bb18486a502f306d9a0f711d15d

Comment 6

[Benjamin Beurdouche [:beurdouche]]

Thank you Martin!