1747402 - Open download when completed can display negative time

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P3)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Attachment: Screenshot from 2021-12-22 20-59-50.png

Note

• Intermittently reproduced on a WI-FI connection

Affected versions

• Nightly 97.0a1 2021-12-22

Affected platforms

• Ubuntu 21.04 Wayland

Steps to reproduce

1. Start any lengthier download, e.g: https://speed.hetzner.de/
2. Before the download is complete, click on the ongoing download so that the elapsed time is replaced with Opening in ...
3. Wait for the download to complete and check the elapsed time

Expected result

• Either display Opening in 0s... longer or change with Opening in a few seconds as for regular download

Actual result

• Opening in -1s... can be spotted right before the file is opened

Additional notes

• We didn't encounter this on Windows 10, even with a network limiter

Comment 1

[Petruta Horea [:phorea], Desktop Test Engineering]

This component may be a better fit, please feel free to revert.

Comment 2

[Micah [:mtigley] (she/her)]

I'm not sure how we end up with negative time values here. I suspect if we want to fix the root issue for this we'd want to take a look at getTimeLeft.

But we do have a string for handling odd values for an ongoing download: Opening when completed…. This is probably what we want to use. For a quick fix, we can add another check for when the time value is less than zero here.

Comment 3

[kabakert]

Attachment: Bug 1747402 - Added check for when time value is less than zero in getFormattedTimeStatus. r=mtigley,niklas

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd384d84f3d0
Added check for when time value is less than zero in getFormattedTimeStatus. r=mtigley

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fd384d84f3d0

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kabakert, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Petruta Horea [:phorea], Desktop Test Engineering]

This issue is no longer reproducible on latest Nightly 98.0a1 2022-01-27.