1747423 - Remove preprocessor variable use of buttonStateHover, buttonStateHoverOrFocus and buttonStateActive

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1747422 +++

This bug covers browser/themes/shared/customizableui/panelUI.inc.css and the macos file using the same replacement as part of selectors.

From a very quick look it seems like we could set a variable on the button, and update the variable for hover/focus that we then end up using for the text/icon. Alternatively, it looks like some of the selectors could be combined if we made more efficient use of classes.

Comment 1

[Sam Foster [:sfoster] (he/him)]

I'm trying to figure out a good path forward here. The selector-parts those variables represent are a little gnarly and error-prone - definitely the kind of thing it would be good to avoid duplicating across all the instances in those files. I can see managing a class on the button to replace the not([disabled],[open]]) bit, but that would still leave the need for a :not(:active) in each selector. Maybe that is enough to make the remainder bearable?

Comment 2

[Sam Foster [:sfoster] (he/him)]

:emilio and :ntim suggest trying to reverse the logic to end up with much simpler, more readable rules, along the lines of

button:hover { color: var(--hover-color) }
button:is([disabled],[open]) { color: inherit }

..I'll see if something like that might work in the various instances.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1747423 - Remove the @buttonState* preprocessor vars from panel toolbarbuttons. r?dao

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1747423 - Remove the @buttonState* preprocessor vars from .subviewradio controls r?dao

Depends on D137346

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1747423 - Remove the @buttonState* preprocessor vars from zoom controls in panelUI.inc.css. r?dao

Depends on D137347

Comment 6

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1747423 - Remove the @buttonState* preprocessor %defines; remove vars from (macos only) .panel-buttons r?dao

Depends on D137348

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdc88799f225
Remove the @buttonState* preprocessor vars from panel toolbarbuttons. r=dao
https://hg.mozilla.org/integration/autoland/rev/fed0f04a2ae2
Remove the @buttonState* preprocessor vars from .subviewradio controls r=dao
https://hg.mozilla.org/integration/autoland/rev/bbcd805fe7e3
Remove the @buttonState* preprocessor vars from zoom controls in  panelUI.inc.css. r=dao
https://hg.mozilla.org/integration/autoland/rev/41400853180c
Remove the @buttonState* preprocessor %defines; remove vars from (macos only) .panel-buttons r=amy

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cdc88799f225
https://hg.mozilla.org/mozilla-central/rev/fed0f04a2ae2
https://hg.mozilla.org/mozilla-central/rev/bbcd805fe7e3
https://hg.mozilla.org/mozilla-central/rev/41400853180c

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.