1747513 - Eyedropper click on picture-in-picture button triggers it

Status: NEW

(Toolkit :: Picture-in-Picture, defect, P4)

Description

[nils]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

1. Start the eyedropper by going to Tools > Browser Tools > Eyedropper
2. Click where the picture-in-picture button is located

Actual results:

Picture-in-picture frame is started and eyedropper is still enabled, the value of the colour has not been copied to the clipboard.

Expected results:

Picture-in-picture frame not started and value of pixel colour copied to clipboard.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Video/Audio Controls' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Micah [:mtigley] (she/her)]

We may need to somehow tell PictureInPicture.onPointerDown about the eyedropper tool being enabled and have it ignore opening the PiP window.

Ania, do you think this would be another "nice-to-have" fix for PiP?

Comment 3

[Ania]

(In reply to [:mtigley] (she/her) from comment #2)

We may need to somehow tell PictureInPicture.onPointerDown about the eyedropper tool being enabled and have it ignore opening the PiP window.

Ania, do you think this would be another "nice-to-have" fix for PiP?

I'd say this is a fairly low priority due to the low likelihood of users running into this problem en masse.
I looked at the priority of other issues in the Outreachy metabug (they have been selected as a high-ish priority from the full PiP backlog), and set the priority to P4. It's nice to have after we address the rest of the P2-P4 defects/enhancements in the metabug.