1747544 - bench.rs: length comparison to zero

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

hs.len() == 0
should use .is_empty() instead

https://searchfox.org/mozilla-central/rev/cc4a22e024a23183e53696bf6dc5014e407a29ff/xpcom/rust/gtest/bench-collections/bench.rs#97

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by https://rust-lang.github.io/rust-clippy/master/#len_zero

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Emilio Cobos Álvarez (:emilio)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #0)

should use .empty() instead

.is_empty() right? :)

Comment 2

[Sylvestre Ledru [:Sylvestre]]

indeed, lazy clone for the C++ equivalent :)
I updated comment #0

Comment 3

[bourg.garrett]

I'd like to give this a shot. I've gone through the first several steps in the contribution guide and I found the right file to update.

Comment 4

[bourg.garrett]

Attachment: Bug 1747544 - Fix lint warning on string comparison in bench.rs. r=nika

Comment 5

[bourg.garrett]

My patch was approved, but I could use some help getting this change landed. Is there a particular place I need to go to ask for assistance from the reviewer?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Using the "Request more information" flag in bugzilla is more effective than commenting on phabricator because comments on phabricator are easy-ish to miss. Nika probably missed it, I've pushed the patch for you. Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11516564cff9
Fix lint warning on string comparison in bench.rs. r=nika

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/11516564cff9