1747548 - Some file types saved by "Save link as" in Private Browsing window are deleted after closing all PB windows

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Fanolian]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0
Build ID: 20211223215735

This bug resembles bug 1738448 but now it's about Save Link As instead of download from pdf.js.

Steps to reproduce

1. Set browser.download.improvements_to_download_panel to true.
2. Open a private browsing window, go to https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/
3. Right click on any .svg link and choose Save Link As.
4. Select a save location and confirm that the browser finishes downloading the file.
   4b (optional). Right click on the file > Properties.
5. Close all private browsing windows.

Actual result

When the file is downloaded:

1. At step 4, it is immediately opened in an external application. (bug 1741431)
2. At Step 4b, file attribute for the file is set to Read-only. (bug 1742754 comment 5)

After closing all PB windows:

The file is deleted.

Expected result

The file is kept even after closing all browser windows because users specifically choose to save the link.

Notes

1. It feels like the bug applies only to files types affected by bug 1741431, i.e. those that will immediately open in associated applications after downloading. (I don't know how to apply the patch in bug 1741431 myself and confirm this.)
2. Unlike bug 1742754, this bug cannot be mitigated by setting browser.helperApps.deleteTempFileOnExit to false. The file is still deleted.

Workaround

Set browser.download.improvements_to_download_panel to false.

Comment 1

[Fanolian]

Preemptively setting this to block bug 1733587 because this causes a data loss.
Setting Firefox 97 as affected because the download improvement will ride the train in Firefox 97.

Comment 2

[Fanolian]

Attachment: handlers.json

handlers.json from an affected newly created profile.

Comment 3

[:Gijs (he/him)]

I'm fairly sure the patch in bug 1741431 will fix this.

Comment 4

[Hani Yacoub, Desktop QA]

Managed to reproduce this issue on Windows 10 x64, macOS 11.6 and on Ubuntu 20.04 x64.

Comment 5

[:Gijs (he/him)]

Today's nightly has the fix from bug 1741431 - can you confirm this is now fixed? :-)

Comment 6

[Fanolian]

This is fixed in 2022-01-06 20220106090415 build. Thanks a lot.

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issues on Windows 10x64 Fx 97.0a1(2021-12-24).
Verified as fixed on Windows 10x64, Ubuntu 18.4 and macOS 10.12.6 with Fx 98.0a1 and Fx 97.0b4.