1747564 - Pressing "Ctrl+Z" to Undo past text in the search box no longer has all previous searches for the window session.

Status: RESOLVED DUPLICATE of bug 1747531

(Firefox :: Search, defect)

Description

[Other Realm]

Attachment: A Screenshot of the Search Box I am talking about

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:96.0) Gecko/20100101 Firefox/96.0

Steps to reproduce:

Entered text into the dedicated search box (not the URL bar) and pressed enter, then got rid of the previous text in the search box, entered new text, and did another search, then tried to undo the new text by pressing Ctrl+Z to go back to the previous search term.

Actual results:

I reported this on support.mozilla.org ( https://support.mozilla.org/en-US/questions/1360991?utm_campaign=questions-reply ) but it appears to be an unreported bug.
The issue is that pressing "Ctrl+Z" in the search box after pressing enter (initiating the search), seems to clear the undo text history (meaning Ctrl-Z no longer works, not that past searches are not saved). It used to remember all previous modifications of the search text area in the window you have open until it was closed. I am not talking about the URL bar, the dedicated search box; the URL bar never remembered your past changes, I don't think. I know it was functional at least until v88 but it now does not work in either the main stream or developer versions (in windows 10). It has been tested on a new profile with no add-ons enabled.

Expected results:

It used to remember all past text changes (irrespective of whether the search was actually submitted, i.e. whether someone pressed enter before changing it) entered in the search box while the window was open.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Other Realm]

Another related support post: https://support.mozilla.org/en-US/questions/1362117

Comment 3

[Hani Yacoub, Desktop QA]

Pressing Ctrl+z after deleting the last entered keyword in the search box will show back that word, but I couldn't see the rest of search history by pressing Ctrl+z.
I'll set this bug as new so the engineering team could take a look at this issue.

Comment 4

[Other Realm]

Component: Toolbars and Customization → Search

Are you sure that it is related to the search functionality? I think it has more to do with the text input in the toolbar, as it still remembers the searches you entered, it is the Ctrl-Z functionality that is broken. Before, it remembered what you typed in the box, irrespective of whether you had actually done a search with that exact term or had thought of a better phrasing and cleared the text before you ever ran a search for it. I think the the correct component is the Toolbars and Customization

Comment 5

[Other Realm]

(In reply to Other Realm from comment #4)

Component: Toolbars and Customization → Search

Are you sure that it is related to the search functionality? I think it has more to do with the text input in the toolbar, as it still remembers the searches you entered, it is the Ctrl-Z functionality that is broken. Before, it remembered what you typed in the box, irrespective of whether you had actually done a search with that exact term or had thought of a better phrasing and cleared the text before you ever ran a search for it. I think the the correct component is the Toolbars and Customization

By "the Ctrl-Z functionality is broken" I mean in a similar way to how it is on a reactive webpage that's HTML is not properly connected to the JavaScript so that forward/back navigation clears the Ctrl-Z history. I think the toolbar has a similar problem, although I could be wrong with that diagnosis.

Comment 6

[Other Realm]

Changed the Severity to S3 as the description "Blocks non-critical functionality" seems most relevant

Comment 7

[gwarser]

[rdk@on ~]$ mozregression -g 91 -b 95
...
===== Downloaded 100% =====
9:38.67 INFO: Running autoland build built on 2021-09-26 01:14:33.748000, revision 4f7e9fe5
9:46.15 INFO: Launching /tmp/tmpavhftcks/firefox/firefox
9:46.15 INFO: Application command: /tmp/tmpavhftcks/firefox/firefox -profile /tmp/tmpv3ogz45d.mozrunner
9:46.15 INFO: application_buildid: 20210926001703
9:46.15 INFO: application_changeset: 4f7e9fe53b44e13edc2813523abefcb0b75e01f0
9:46.15 INFO: application_name: Firefox
9:46.15 INFO: application_repository: https://hg.mozilla.org/integration/autoland
9:46.15 INFO: application_version: 94.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry' or 'exit' and press Enter): good
9:59.18 INFO: Narrowed integration regression window from [a3f0791a, 9237deee] (3 builds) to [4f7e9fe5, 9237deee] (2 builds) (~1 steps left)
9:59.18 INFO: No more integration revisions, bisection finished.
9:59.18 INFO: Last good revision: 4f7e9fe53b44e13edc2813523abefcb0b75e01f0
9:59.18 INFO: First bad revision: 9237deee110beeaa7605195528a273b2bbc77352
9:59.18 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4f7e9fe53b44e13edc2813523abefcb0b75e01f0&tochange=9237deee110beeaa7605195528a273b2bbc77352

STR on Manjaro KDE:

• search bar enabled by policy
• click search bar, type a, enter
• click search bar, type b, enter
• click search bar, type c, enter
• click search bar, type Ctrl+z few times

Comment 8

[gwarser]

Duplicate of bug 1747531