1747618 - Support windows 11 non-overlay scrollbar style.

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: image.png

At least on my Windows 11 version, apps that use non-overlay scrollbars get a thicker thumb, see screenshot of the "native" scrollbars drawn by task manager (they also are drawn like this in nsNativeTheme).

We also still paint Windows 10 scrollbars on windows 11 with dark theme and "native" scrollbars, which we should probably fix.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Center by default scrollbar arrow X points, fix arrow painting, and document magic numbers. r=spohl

Right arrow was being painted pointing to the wrong direction.

Having the points being centered and displace them is easier to reason
about, IMO.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Implement non-overlay scrollbar style for Win11. r=spohl

Add a pref to force the small scrollbar even in
non-overlay-scrollbars mode (which is the current behavior).

Depends on D134679

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Make overlay scrollbars usable on Windows. r=spohl

Very trivial changes that make overlay scrollbars work on Windows.

Depends on D134680

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Center by default scrollbar arrow X points, fix arrow painting, and document magic numbers. r=spohl

Right arrow was being painted pointing to the wrong direction.

Having the points being centered and displace them is easier to reason
about, IMO.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Implement non-overlay scrollbar style for Win11. r=spohl

Add a pref to force the small scrollbar even in
non-overlay-scrollbars mode (which is the current behavior).

Depends on D134682

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Make overlay scrollbars usable on Windows. r=spohl

Very trivial changes that make overlay scrollbars work on Windows.

Depends on D134683

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Always draw scrollbars using the non-native theme on Windows. r=spohl

Much like GTK. This ensures consistent scrollbar styles across Firefox.

Depends on D134684

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Fix non-unified build in various scrollbar drawing code. r=spohl

Depends on D134685

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Make Win11 scrollbar drawing work better with custom scrollbar sizes. r=spohl

This is useful so it doesn't look ugly with custom sizes (which might be useful
for accessibility features), but it will also be necessary for scrollbar-width:
thin.

Depends on D134689

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1747618 - Support scrollbar-width: thin in win11 scrollbars. r=spohl

This also makes two tweaks:

• Consistently applies hover / active feedback independent of scrollbar-color.
• Apply scrollbar-color to scrollbar buttons too.

Depends on D134690

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e01214655e0
Center by default scrollbar arrow X points, fix arrow painting, and document magic numbers. r=spohl
https://hg.mozilla.org/integration/autoland/rev/6d3bc5473a1e
Implement non-overlay scrollbar style for Win11. r=spohl
https://hg.mozilla.org/integration/autoland/rev/3f5065553270
Make overlay scrollbars usable on Windows. r=spohl
https://hg.mozilla.org/integration/autoland/rev/56a5f901ac95
Always draw scrollbars using the non-native theme on Windows. r=spohl
https://hg.mozilla.org/integration/autoland/rev/6c2ec190cd1f
Fix non-unified build in various scrollbar drawing code. r=spohl
https://hg.mozilla.org/integration/autoland/rev/4e9ae7efa612
Make Win11 scrollbar drawing work better with custom scrollbar sizes. r=spohl
https://hg.mozilla.org/integration/autoland/rev/051c8cc7021c
Support scrollbar-width: thin in win11 scrollbars. r=spohl

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0e01214655e0
https://hg.mozilla.org/mozilla-central/rev/6d3bc5473a1e
https://hg.mozilla.org/mozilla-central/rev/3f5065553270
https://hg.mozilla.org/mozilla-central/rev/56a5f901ac95
https://hg.mozilla.org/mozilla-central/rev/6c2ec190cd1f
https://hg.mozilla.org/mozilla-central/rev/4e9ae7efa612
https://hg.mozilla.org/mozilla-central/rev/051c8cc7021c