174775 - Javascript popup URLs no longer work in the Personal Toolbar Folder

Status: RESOLVED WORKSFORME

(SeaMonkey :: Bookmarks & History, defect)

Description

[Kim Scarborough]

I have a few URLs like the one above in my Personal Toolbar Folder. They will
search for highlighted text on the current page at the given site, and, if no
text is highlighted, a popup window will come up and allow you to enter text. As
of 1.2, the popup window no longer comes up, although it will still do the
highlighted search. It does work in 1.1.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Out of curiousity, if you allow unrequested windows does it work?

Comment 2

[Kim Scarborough]

Argh... yes, it sure does (I had to restart though). This is still a bug,
though, right? I mean, this isn't an "unrequested" window and it worked in
previous versions although I always had unrequested windows turned off.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Dan, this is yours...  sounds like bookmarklets run on a timeout or something
and they are running in the page's context, not chrome context.  So we block the
prompt() call, because it looks just like a prompt() in an onload handler...

Comment 4

[Dan M]

  I love tricky bookmarks like that. Sorry to have busted them on you.
  That said, I can't really reproduce this. I did see it once, but I'm unable to
do it again. However the patch in bug 173016 really should fix this problem as
well. Marking dependent.

Comment 5

[Chris Lyon]

*** Bug 175349 has been marked as a duplicate of this bug. ***

Comment 6

[u60234]

Build ID:2002101904 on Windows 98.

With "Reject pop-up windows" checked I can reproduce this by open more than one
tab and then close a tab, then a bookmarklet like the above will not work.

If I then open another tab or open (or close and open) the Sidebar, it will work
until I close a tab again.

I also noticed that there seems to be no way to get a promt with about:config or
about: as the active tab. No problem with about:plugins though.

Comment 7

[Dan M]

Popup blocking has been backed out. When it returns, it won't block alerts.
Marking fixed.

Comment 8

[Kim Scarborough]

I'm seeing this behavior again in FreeBSD builds (from the FreeBSD ports) of
1.2.1 and 1.3a. Windows version is fine. Should I reopen this bug or open a new one?

Comment 9

[Kim Scarborough]

I've not received a response to comment 8, so I'm reopening this bug, changing
the OS to FreeBSD. 

Comment 10

[Kim Scarborough]

Okay, now it's working, although I didn't upgrade. Must be this stuff I'm
smoking. Sorry about that.