1747925 - Revert pointer-arithmetic change in malloc_in_sandbox

Status: RESOLVED FIXED

(Core :: Security: RLBox, defect)

Description

[Bobby Holley (:bholley)]

In bug 1747514 I made a drive-by correction of some unrelated pointer arithmetic, and we've now realized that the original logic was correct. Filing this bug to revert that part of the change.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 1747925 - Revert pointer-arithmetic change in malloc_in_sandbox.

Because get_unsandboxed_pointer is templated, the original code was
correct.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5af373ef26d
Revert pointer-arithmetic change in malloc_in_sandbox. r=shravanrn

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 9257068 [details]
Bug 1747925 - Revert pointer-arithmetic change in malloc_in_sandbox.

Beta/Release Uplift Approval Request

• User impact if declined: Slightly weakened security sandbox.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very low risk, just reverts a ride-along change from bug 1747514 (which was recently uplifted to beta).
• String changes made/needed:

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c5af373ef26d

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1747514

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9257068 [details]
Bug 1747925 - Revert pointer-arithmetic change in malloc_in_sandbox.

Approved for 96.0rc1

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5adb05c5363a