1747929 - UrlbarSearchUtils.enginesForDomainPrefix() can include the same engine more than once when matchAllDomainLevels = true (partial matching)

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

If UrlbarSearchUtils.enginesForDomainPrefix() is called with matchAllDomainLevels set, then a single engine can end up more than once in the list of returned matching engines.

I found this while working on bug 1744367.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1747929 - Modify UrlbarSearchUtils.enginesForDomainPrefix() so it does not include the same engine more than once when matchAllDomainLevels = true.

• Don't include partially matching engines that are already in the perfectly
  matching list
• Add a test for this and the matchAllDomainLevels case in general since we
  don't have one AFAICT
• The test file name ends in jsm, so change it to js

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca42b190bcdd2a856796ebb3639c3e8f44dcbcb3

I'll go ahead and mark this as a regression since before bug 1668939 this function would not have returned duplicate engines.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1668939

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f8d0a814b2e
Modify UrlbarSearchUtils.enginesForDomainPrefix() so it does not include the same engine more than once when matchAllDomainLevels = true. r=harry

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6f8d0a814b2e

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:adw, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.