1748046 - Toolchain tasks running on mac workers are busted

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Mike Hommey [:glandium]]

Example:

[task 2021-12-31T02:02:31.129Z] executing ['bash', '-cx', "'$GECKO_PATH/taskcluster/scripts/misc/pack.sh' /Applications/Xcode-12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk"]
[task 2021-12-31T02:02:31.134Z] + '$GECKO_PATH/taskcluster/scripts/misc/pack.sh' /Applications/Xcode-12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk
[task 2021-12-31T02:02:31.134Z] bash: $GECKO_PATH/taskcluster/scripts/misc/pack.sh: No such file or directory

The problem is they're trying to use $GECKO_PATH literally, not expanding it, which comes from the shell quoting that happens in the toolchain transform.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1748046 - Don't quote the first element in toolchain task commands.

This gets us closer to what we had before bug 1743742.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7434ddfffd98
Don't quote the first element in toolchain task commands. r=taskgraph-reviewers,aki

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7434ddfffd98

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1743742

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 9257207 [details]
Bug 1748046 - Don't quote the first element in toolchain task commands.

Beta/Release Uplift Approval Request

• User impact if declined: If for some reason we trigger a rebuild of all toolchains, the affected tasks will fail and everything that will depend on them won't happen (effectively every mac build and test)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB taskcluster task graph code with controlled effects.
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9257207 [details]
Bug 1748046 - Don't quote the first element in toolchain task commands.

96 is on release now.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9257207 [details]
Bug 1748046 - Don't quote the first element in toolchain task commands.

Approved for 96.0rc2

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/5cb2173ad640