1748138 - image file size in image info dialog is unknown with top-level site partitioning

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Sören Hentzschel]

STR:

1. set browser.menu.showViewImageInfo to true
2. open a website
3. open the context menu of an image and select the menu item for the image info

Expected:

You can see the file size of the image.

Actual:

The first time the file size is always "Unknown (not cached)" for every image. After repeating step 3 there is a file size.

This is a regression that was introduced with the top-level site partitioning. Setting privacy.partition.network_state to false "fixes" the issue but it's of course not really a fix.

(setting bug 1681330 as regressing bug since it's the bug where it got enabled for stable releases)

Comment 1

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1748138 - Modified cache checks to account for partition key taken from content process. r?#anti-tracking

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93efae7712c8
Modified cache checks to account for partition key taken from content process. r=anti-tracking-reviewers,timhuang,mconley

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/93efae7712c8

Comment 4

[Cristina Horotan [:chorotan]]

Backed out changeset 93efae7712c8 (Bug 1748138) for causing bc failures at browser_devices_get_user_media_in_xorigin_frame.js on OS X 11 WebRender Shippable platform

Backout: https://hg.mozilla.org/integration/autoland/rev/51221b6d7ce2b112a9a3dc1470ff708cdeb5c883

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=93efae7712c8170b189d6e2d626af9bc74ee9f33&selectedTaskRun=V3S4s3kbSOaebZjBzbH5Bw.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=422601306&repo=autoland&lineNumber=2743
https://treeherder.mozilla.org/logviewer?job_id=422608482&repo=autoland&lineNumber=7186

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49854f277e56
Modified cache checks to account for partition key taken from content process. r=anti-tracking-reviewers,timhuang,mconley a=reland

Comment 6

[Iulian Moraru]

This was re-landed. Sorry for any inconvenience caused by this.

Comment 7

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/51221b6d7ce2

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/49854f277e56