1748146 - Too much recursion error in /streams/writable-streams/aborting.any.worker.html

Status: RESOLVED FIXED

(Core :: DOM: Streams, defect)

Description

[Tom S. (please needinfo tschuster)]

When running this test we get a "too much recursion" error.

This seems to be caused by firing the signal's abort event synchronously with writer.abort(e2), while inside the abort event listener. Not sure if this is a test issue or if the event should be dispatched differently or something else entirely.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Aborting an already aborted writer should do nothing I guess?

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

The "should do nothing" part is in https://dom.spec.whatwg.org/#abortsignal-signal-abort

If signal is aborted, then return.

AbortSignal::SignalAbort should return early but current only AbortSignalImpl::SignalAbort does.

Comment 3

[Tom S. (please needinfo tschuster)]

AbortSignal::SignalAbort should return early but current only AbortSignalImpl::SignalAbort does.

Nice! Sounds like we can just add an early return before calling AbortSignalImpl::SignalAbort. I do wonder why that method doesn't dispatch the "abort" event as well.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

I believe it's because the impl one is only for internal use. Do you want to work on this?

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

(I will)

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1748146 - Return early in AbortSignal::SignalAbort r=smaug!

Currently only AbortSignalImpl::SignalAbort returns early. Both can be called directly, so both should return early.

Currently not really testable since this is only problematic in dom/streams and it's still hidden by a build flag.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6b75d021d28
Return early in AbortSignal::SignalAbort r=smaug

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f6b75d021d28