1748435 - [wpt-sync] Sync PR 32237 - Add testing coverage for `animation-composition`

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32237 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32237
Details from upstream follow.

Antoine Quint <[e-mail]> wrote:

Add testing coverage for animation-composition

There is no test coverage for the animation-composition property. At the moment that property is not implemented by any browser engine that I know of, but WebKit plans to implement it soon. It should be straightforward for Gecko and Blink to add support as well considering they have long-established support for Web Animations composite operations and this CSS property uses existing patterns to expose Web Animations features in CSS Animations.

Adding support for this property in WebKit is tracked by WebKit bug 232086.

I believe these changes are exhaustive and comparable to other animation- CSS properties for parsing support. I'll note a couple of more specific things:

• css/css-animations/CSSAnimation-effect.tentative.html: check that setting animation-composition sets the composite property on the effect itself,
• css/css-animations/KeyframeEffect-getKeyframes.tentative.html: check that animation-composition is accounted for when set on keyframes within a @keyframes rule to de-duplicate keys, along with the offset and the timing function.

The rest of the changes are pretty standard.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ce9a0e0206ed03fbe43a00f56d71ede8f532511

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 62 subtests

Status Summary

Firefox

OK : 6
PASS: 81
FAIL: 26

Chrome

OK : 6
PASS: 93
FAIL: 14

Safari

OK : 6
PASS: 73
FAIL: 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-pseudo/parsing/marker-supported-properties.html
Property letter-spacing value '10px' in ::marker: FAIL linked bug:Bug 1673735
Property line-break value 'anywhere' in ::marker: FAIL linked bug:Bug 1673735
Property overflow-wrap value 'anywhere' in ::marker: FAIL linked bug:Bug 1673735
Property tab-size value '10px' in ::marker: FAIL linked bug:Bug 1673735
Property word-break value 'break-word' in ::marker: FAIL linked bug:Bug 1673735
Property word-spacing value '10px' in ::marker: FAIL linked bug:Bug 1673735
Property text-decoration-skip-ink value 'none' in ::marker: FAIL linked bug:Bug 1673735
Property text-emphasis-color value 'rgb(0, 255, 0)' in ::marker: FAIL
Property text-emphasis-position value 'under left' in ::marker: FAIL
Property text-shadow value 'rgb(0, 255, 0) 1px 2px 3px' in ::marker: FAIL linked bug:Bug 1673735

New Tests That Don't Pass

/css/css-animations/parsing/animation-composition-computed.tentative.html
Property animation-composition value 'replace, add, accumulate': FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-animations/CSSAnimation-effect.tentative.html
Setting animation-composition sets the composite property on the effect: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-animations/KeyframeEffect-getKeyframes.tentative.html
KeyframeEffect.getKeyframes() returns frames with expected composite values, when the composite is specified on each keyframe: FAIL (Chrome: FAIL, Safari: FAIL)
KeyframeEffect.getKeyframes() returns frames with expected composite values, when the composite is specified on some keyframes: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-animations/parsing/animation-composition-valid.tentative.html
e.style['animation-composition'] = "replace" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['animation-composition'] = "add" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['animation-composition'] = "accumulate" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['animation-composition'] = "replace, add, accumulate" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/parsing/marker-supported-properties.html
Property font-synthesis-small-caps value 'none' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property font-synthesis-style value 'none' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property font-synthesis-weight value 'none' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property animation-composition value 'add' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property hyphens value 'none' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property letter-spacing value '10px' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property line-break value 'anywhere' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property overflow-wrap value 'anywhere' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property tab-size value '10px' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property word-break value 'break-word' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property word-spacing value '10px' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property text-decoration-skip-ink value 'none' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property text-emphasis value 'dot rgb(0, 255, 0)' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property text-emphasis-color value 'rgb(0, 255, 0)' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property text-emphasis-position value 'under left' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property text-emphasis-style value 'dot' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property text-shadow value 'rgb(0, 255, 0) 1px 2px 3px' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property list-style value 'inside url('foo') decimal' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e6bff025caf0
https://hg.mozilla.org/mozilla-central/rev/07f1c193d1c1