Closed Bug 1748631 Opened 3 years ago Closed 3 years ago

Cleanup/Refactor inspector node event listeners info server code

Categories

(DevTools :: Inspector, task)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(firefox97 fixed)

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

Bug 1748631 - [devtools] Refactor Node event listeners server codepath. r=ochameau.
48 bytes, text/x-phabricator-request
Details | Review

There are a few things that could be improved in event-collector.js to make the code easier to follow.

  • Remove NodeActor#getEventListeners which was simply a proxy to EventCollector#getEventListeners
  • Change signature of EventCollector#processHandlerForEvent to make code easier to follow

Depends on D135127

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d39b3b5f84c [devtools] Refactor Node event listeners server codepath. r=ochameau.

https://hg.mozilla.org/mozilla-central/rev/4d39b3b5f84c

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: