1748865 - Add mozilla::ipc::IProtocol::ChannelSend to the prefix list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Andrew McCreight [:mccr8]]

As seen in bug 1748843, it looks like we can end up with null crashes when calling various send methods with null actors. I think this is an issue with each call site, not an issue with the internals of the ChannelSend method, so this should be added to the prefix list.

Here's an example crash: bp-0a007ca9-7590-45b4-8c3e-dab230220106

In some sense, it might be nice to have some kind of gnarly regexp to also match the various actor Send methods for the prefix list, but in practice each send method has very few call sites so it probably isn't worth the hassle.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5967: bug 1748865: add mozilla::ipc::IProtocol::ChannelSend to prefix list

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5967: "bug 1748865: add mozilla::ipc::IProtocol::ChannelSend to prefix list" in ef403b7.

Comment 3

[Andrew McCreight [:mccr8]]

Thanks!

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Thank you for writing up a perfect request! It clearly walked through the issue so I knew what needed to get done and what we should be expecting, it had an example crash report, and it talked about the symbol in question so we know what we did and why in case future us needs to understand the context. I really appreciate it!

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed earlier today in bug #1749582. Marking as FIXED.