1748888 - PromiseNativeHandler::[Resolved,Rejected]Callback needs a way to indicate failures

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Tom S]

Right now the ResolvedCallback/RejectedCallback methods don't return bool or have a ErrorResult parameter. We need either of those to be able to propagate failures from the streams code implementation of those callbacks.

Comment 1

[Tom S]

I just realized that this needs to block shipping. We now call MaybeSetPendingException in various Callback methods. This means we can have a pending exception, but return true in a JS Native: https://searchfox.org/mozilla-central/source/dom/promise/Promise.cpp#345. This is an invalid state and might cause assertions.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: WIP: Bug 1748888 - Support fallible PromiseNativeHandling

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: WIP: Bug 1748888 - Alternative implementation that adds FalliblePromiseNativeHandler

This doesn't link however, as it's complaining about an undefined vtable for
FalliblePromiseNativeHandler... I suspect some confusion about how nsIsupports
is connected here

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1748888 - Add ErrorResult parameter to PromiseNativeHandler callbacks r?smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24818df95358
Add ErrorResult parameter to PromiseNativeHandler callbacks r=smaug

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/24818df95358