1748947 - Error: File resource://default-theme/ does not contain a valid manifest

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P3)

Description

[Tomas Krasny]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36

Steps to reproduce:

I use latest GeckoView in my Android App. I use exactly the same code in my app as listed on your github (https://mozilla.github.io/geckoview/)

Actual results:

When I open my app it crash after 3 seconds and just what I get in debug console is: E/GeckoConsole: [JavaScript Error: "Error: File resource://default-theme/ does not contain a valid manifest" {file: "resource://gre/modules/addons/XPIInstall.jsm" line: 656}]
[JavaScript Error: "Error: File resource://default-theme/ does not contain a valid manifest" {file: "resource://gre/modules/addons/XPIInstall.jsm" line: 656}]

Expected results:

It should show desired website location

Comment 1

[Rob Wu [:robwu]]

FYI: That error message about default-theme is likely not the cause for the observed crash.

If at all relevant, the crash is more likely bug 1748506 (or a variant of it).

Comment 2

[Rob Wu [:robwu]]

The error message doesn't do much, but since themes aren't used on GeckoView/Fenix, perhaps we should skip this call on Android:

https://searchfox.org/mozilla-central/rev/72c7cef167829b6f1e24cae216fa261934c455fc/toolkit/mozapps/extensions/internal/XPIProvider.jsm#2501-2505

More broadly, I wonder whether we should disable the theme API and/or remove the "theme" addon type altogether on Android.

Comment 3

[Tomislav Jovanovic :zombie]

Probably a questino for Agi.

Comment 4

[Rob Wu [:robwu]]

(In reply to Rob Wu [:robwu] from comment #2)

More broadly, I wonder whether we should disable the theme API and/or remove the "theme" addon type altogether on Android.

The theme add-on type (and others) were disabled in bug 1867873.

The error message from the report is still occurring though. When I run the following test (using ./mach xpcshell-test instead of ./mach test to ignore the skip-if = ['os == "android"] directive):

./mach xpcshell-test toolkit/mozapps/extensions/test/xpcshell/test_builtin_location.js

the output is:

 0:02.80 INFO xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_builtin_location.js | Starting test_builtin_location
 0:02.80 INFO (xpcshell/head.js) | test test_builtin_location pending (2)
 0:02.87 INFO (xpcshell/head.js) | test run_next_test 0 finished (2)
 0:02.87 ERROR Unexpected exception Error: File resource://default-theme/ does not contain a valid manifest at resource://gre/modules/addons/XPIInstall.sys.mjs:705
loadManifest@resource://gre/modules/addons/XPIInstall.sys.mjs:705:11
async*installBuiltinAddon@resource://gre/modules/addons/XPIInstall.sys.mjs:4697:23
XPIProvider[meth]@resource://gre/modules/addons/XPIProvider.sys.mjs:3338:39
maybeInstallBuiltinAddon@resource://gre/modules/addons/XPIProvider.sys.mjs:3017:26
startup@resource://gre/modules/addons/XPIProvider.sys.mjs:2548:12
callProvider@resource://gre/modules/AddonManager.sys.mjs:228:31
_startProvider@resource://gre/modules/AddonManager.sys.mjs:537:17
startup@resource://gre/modules/AddonManager.sys.mjs:750:14
startup@resource://gre/modules/AddonManager.sys.mjs:3684:26
observe@resource://gre/modules/amManager.sys.mjs:73:29
promiseStartupManager@resource://testing-common/AddonTestUtils.sys.mjs:853:34
test_builtin_location@test_builtin_location.js:32:24
_run_next_test/<@/data/local/tmp/test_root/xpc/head.js:1759:22
_run_next_test@/data/local/tmp/test_root/xpc/head.js:1759:38
run@/data/local/tmp/test_root/xpc/head.js:808:9
_do_main@/data/local/tmp/test_root/xpc/head.js:245:6
_execute_test@/data/local/tmp/test_root/xpc/head.js:596:5
@-e:1:1

Comment 5

[Rob Wu [:robwu]]

Many tests are failing for this reason; I've annotated them in bug 1872867:

• toolkit/mozapps/extensions/test/xpcshell/test_builtin_location.js
• toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js
• toolkit/mozapps/extensions/test/xpcshell/test_safemode.js
• toolkit/mozapps/extensions/test/xpcshell/test_sideload_scopes.js
• toolkit/mozapps/extensions/test/xpcshell/test_sideloads_after_rebuild.js
• toolkit/mozapps/extensions/test/xpcshell/test_startup.js
• toolkit/mozapps/extensions/test/xpcshell/test_startup_scan.js
• toolkit/mozapps/extensions/test/xpcshell/test_system_profile_location.js
• toolkit/mozapps/extensions/test/xpcshell/test_system_upgrades.js
• toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js

Comment 6

[Rob Wu [:robwu]]

Attachment: Bug 1748947 - Stop trying to install non-existent default-theme on Android

Removed the 10 skip-ifs that are associated with this unwanted error.

And fixed an unrelated issue in test_startup.js that prevented the test
from passing on Android, even with the bugfix.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6790e0df24b6
Stop trying to install non-existent default-theme on Android r=willdurand

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6790e0df24b6