Closed Bug 1748975 Opened 3 years ago Closed 2 years ago

Check whether untrusted keypress event should trigger a click event

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: edgar, Assigned: avandolder)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Assignee: nobody → avandolder
Status: NEW → ASSIGNED
Pushed by avandolder@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/879e2ae70979
Don't trigger click event on untrusted keypresses for buttons and summaries. r=edgar
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35551 for changes under testing/web-platform/tests

Backed out for causing reftest failures on key-enter-single-summary.html, key-space-single-summary.html

Backout link

Push with failures

Failure log

Failure lines:
(1) REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/details-summary/key-enter-single-summary.html == layout/reftests/details-summary/open-single-summary.html | image comparison, max difference: 255, number of differing pixels: 656
(2) REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/details-summary/key-space-single-summary.html == layout/reftests/details-summary/open-single-summary.html | image comparison, max difference: 255, number of differing pixels: 656

Flags: needinfo?(avandolder)
Upstream PR was closed without merging

These tests seem to rely on the broken behaviour that this patch is fixing, and I must have missed them when testing it myself. I'll make sure to fix them.

Flags: needinfo?(avandolder) → needinfo?(echen)

Left some comments on phabricator. Thanks!

Flags: needinfo?(echen)
Pushed by avandolder@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e097a76ee174
Don't trigger click event on untrusted keypresses for buttons and summaries. r=edgar
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: