1748975 - Check whether untrusted keypress event should trigger a click event

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Edgar Chen [:edgar]]

Input elements will not allow untrusted keypress event to trigger a click event after bug 1695636, this bug is filed to check other elements like,

• https://searchfox.org/mozilla-central/rev/682e5a82d403974bacb779c1db515962d946be48/dom/html/HTMLButtonElement.cpp#237
• https://searchfox.org/mozilla-central/rev/682e5a82d403974bacb779c1db515962d946be48/dom/html/HTMLSummaryElement.cpp#65

Comment 1

[Adam Vandolder [:avandolder]]

Attachment: Bug 1748975 - Don't trigger click event on untrusted keypresses for buttons and summaries. r?edgar

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/879e2ae70979
Don't trigger click event on untrusted keypresses for buttons and summaries. r=edgar

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35551 for changes under testing/web-platform/tests

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing reftest failures on key-enter-single-summary.html, key-space-single-summary.html

Backout link

Push with failures

Failure log

Failure lines:
(1) REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/details-summary/key-enter-single-summary.html == layout/reftests/details-summary/open-single-summary.html | image comparison, max difference: 255, number of differing pixels: 656
(2) REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/details-summary/key-space-single-summary.html == layout/reftests/details-summary/open-single-summary.html | image comparison, max difference: 255, number of differing pixels: 656

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Adam Vandolder [:avandolder]]

These tests seem to rely on the broken behaviour that this patch is fixing, and I must have missed them when testing it myself. I'll make sure to fix them.

Comment 7

[Edgar Chen [:edgar]]

Left some comments on phabricator. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e097a76ee174
Don't trigger click event on untrusted keypresses for buttons and summaries. r=edgar

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e097a76ee174

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot