1749248 - Add missing language names in MozIntl.jsm

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Francesco Lodolo [:flod]]

The list that was used is missing the last locales we added to Firefox builds (sco, szl).

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1749248 - Add missing language names (sco, szl) to MozIntl map, r=#platform-i18n-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e23f777208cc
Add missing language names (sco, szl) to MozIntl map, r=platform-i18n-reviewers,dminor

Comment 3

[eloli]

I got messages from [e-mail] , that list of native language was related to https://bugzilla.mozilla.org/show_bug.cgi?id=1481729

https://bugzilla.mozilla.org/show_bug.cgi?id=1481729#5 :

Sorry to create another exception from CLDR again, but we use 正體中文 project-wise for Traditional Chinese...
https://transvision.mozfr.org/?recherche=Traditional+Chinese&repo=gecko_strings&sourcelocale=en-US&locale=zh-TW&search_type=strings

But that's not exactly right, if you clicked into, you will see different answers

Traditional Chinese (Hong Kong)
正體中文（繁體，香港） , not 正體中文（香港）

Traditional Chinese (Taiwan)
正體中文（繁體，臺灣）, not 正體中文（臺灣）

In short, Traditional Chinese = 繁體中文（HK）/ 正體中文（TW）. You know, zh-HK = zh-TW in Firefox

Back to the point, 简体中文 → 中文 (简体) ✔️ 正體中文 → 正體中文 (繁體) ✔️

Just like AMO: https://s2.loli.net/2022/01/10/fY1uW7UJdQMOZoa.png
Just like Português (BR) and Português (PT) , () ()

Comment 4

[Francesco Lodolo [:flod]]

As explained before, please file a new bug, don't add comments to existing bugs. This bug is about adding language names that were missing, and will be fixed once the patch already approved landed. Your request requires a conversation with a different set of people.

You can use this link, feel free to just copy your comment above.
https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=Internationalization

Comment 5

[Francesco Lodolo [:flod]]

Actually, I'm going to file a new bug to avoid further confusion.

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e23f777208cc

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 9258262 [details]
Bug 1749248 - Add missing language names (sco, szl) to MozIntl map, r=#platform-i18n-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Silesian language will be displayed in English instead of its localized name (for Scots, the language name is identical).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This completes the work done in bug 1476781, which landed for fx97 with an old list, missing 2 languages that we now have in beta/release.
• String changes made/needed: None

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9258262 [details]
Bug 1749248 - Add missing language names (sco, szl) to MozIntl map, r=#platform-i18n-reviewers!

Approved for 97 Beta 2. Thanks.

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ae7e1914aca