1749290 - Amazon pin icon moves when expanding the Address Bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: pin_amazon.gif

Affected versions

• 97.0a1 (20220105093353)
• 96.0 (20220106144528)
• 95.0.2

Affected platforms

• Windows 10x64
• macOS 10.15
• Ubuntu 20.04

Steps to reproduce

1. Open Firefox and pin Amazon from the Top Sites section.
2. Click the Address Bar to expand.
3. Observe the Amazon Pin icon.

Expected result

• Address bar opens as expected.

Actual result

• The Amazon pin icon moves down when the address bar is expanded.

Regression range

• Last good revision: ff220475fee8b11104548853a74b021a1718f47e
  First bad revision: 120f83c79d5c22ea8cf344bd901de79333dc035b
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ff220475fee8b11104548853a74b021a1718f47e&tochange=120f83c79d5c22ea8cf344bd901de79333dc035b

Notes

• Screen recording attached.

Comment 1

[Drew Willcoxon :adw]

I can reproduce this on the latest Nightly on Mac but it's very subtle in my case. I can't see it unless I make a screen recording and slow it down.

The regression range is all l10n changes in bug 1613705, which seem unrelated at first, but they're plausible. What happens is:

1. The view opens, and the Amazon favicon and pinned badge appear immediately. The result title does not appear
2. After a moment, the "Search with Amazon.com" result title pops in, and the pinned badge shifts down

It's not great the title pops in after the view opens, but setting that aside, we should be able (hopefully) to make sure the pinned badge doesn't move regardless.

We cached a bunch of view strings in bug 1727601 so at first I was confused by this, but I think the result title in this case comes from the top sites data, not an l10n string in the view.

Comment 2

[Mark Banner (:standard8)]

Only happens with websites where we have pinned shortcuts & localise them.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1749290: Make the y position of type-icon dependent on center.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29371daf4778
Make the y position of type-icon dependent on center. r=desktop-theme-reviewers,adw,dao

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/29371daf4778

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on Firefox 104.0(build ID: 20220818191623) on macOS 12 using the STR from the Description. Verified as fixed on Firefox 105.0b4(build ID: 20220828190315) and Nightly 106.0a1(build ID: 20220828210513) on macOS 12, Ubuntu 22.04, Windows 10.