Closed Bug 1749290 Opened 9 months ago Closed 2 months ago

Amazon pin icon moves when expanding the Address Bar

Categories

(Firefox :: Address Bar, defect, P3)

Desktop
All
defect
Points:
3

Tracking

()

VERIFIED FIXED
105 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- wontfix
firefox95 --- wontfix
firefox96 --- wontfix
firefox97 --- wontfix
firefox98 --- wontfix
firefox104 --- wontfix
firefox105 --- verified

People

(Reporter: atrif, Assigned: daisuke)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [snt-scrubbed][search-regression])

Attachments

(2 files)

Attached image pin_amazon.gif

Affected versions

  • 97.0a1 (20220105093353)
  • 96.0 (20220106144528)
  • 95.0.2

Affected platforms

  • Windows 10x64
  • macOS 10.15
  • Ubuntu 20.04

Steps to reproduce

  1. Open Firefox and pin Amazon from the Top Sites section.
  2. Click the Address Bar to expand.
  3. Observe the Amazon Pin icon.

Expected result

  • Address bar opens as expected.

Actual result

  • The Amazon pin icon moves down when the address bar is expanded.

Regression range

Notes

  • Screen recording attached.
Has Regression Range: --- → yes
Has STR: --- → yes

I can reproduce this on the latest Nightly on Mac but it's very subtle in my case. I can't see it unless I make a screen recording and slow it down.

The regression range is all l10n changes in bug 1613705, which seem unrelated at first, but they're plausible. What happens is:

  1. The view opens, and the Amazon favicon and pinned badge appear immediately. The result title does not appear
  2. After a moment, the "Search with Amazon.com" result title pops in, and the pinned badge shifts down

It's not great the title pops in after the view opens, but setting that aside, we should be able (hopefully) to make sure the pinned badge doesn't move regardless.

We cached a bunch of view strings in bug 1727601 so at first I was confused by this, but I think the result title in this case comes from the top sites data, not an l10n string in the view.

Points: --- → 3
Priority: -- → P3
See Also: → 1727601

Only happens with websites where we have pinned shortcuts & localise them.

Whiteboard: [snt-scrubbed][search-regression]
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29371daf4778
Make the y position of type-icon dependent on center. r=desktop-theme-reviewers,adw,dao
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Flags: qe-verify+

I managed to reproduce this issue on Firefox 104.0(build ID: 20220818191623) on macOS 12 using the STR from the Description. Verified as fixed on Firefox 105.0b4(build ID: 20220828190315) and Nightly 106.0a1(build ID: 20220828210513) on macOS 12, Ubuntu 22.04, Windows 10.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.