1749431 - firefox sometimes freezes visually on Macbook pro w/ M1 chip

Status: NEW

(Core :: Widget: Cocoa, defect, P2)

Description

[Marc Leclair [:mleclair]]

Attachment: Stacktrace of the crash

I just switched to the M1 MacBook pro 2021 and while I was building something in the background, my Firefox kept crashing ( which wouldn't happen before on an older machine).

I have the M1 16 inch macbook pro with 64gb ram.
I had multiple tabs open (~15):

• developer.android.com
• mozilla.org
• mercurial website
• phabricator x 2
• amazon
• Reddit x 2
• Twitch with a running stream ( no picture in picture)

I attached the stack trace given by the pc.

Comment 1

[Stephen A Pohl [:spohl]]

The attached stack shows a hang rather than a crash. Would you be able to collect a performance profile and upload it? I'm cc'ing Markus in case he has additional recommendations about the specific profile to collect.

Link to profiler: https://profiler.firefox.com/
Docs for the built-in profiler: https://profiler.firefox.com/docs/#/

Comment 2

[Markus Stange [:mstange]]

If it's an infinite hang it'll be hard to capture a profile of it.
The event loop looks idle. This could be a bug where our vsync notifications are broken and we stop redrawing the window.

Marc, when Firefox gets into this state, can you "force" repaints by resizing the window or by focusing / unfocusing windows?

Comment 3

[Marc Leclair [:mleclair]]

(In reply to Markus Stange [:mstange] from comment #2)

If it's an infinite hang it'll be hard to capture a profile of it.
The event loop looks idle. This could be a bug where our vsync notifications are broken and we stop redrawing the window.

Marc, when Firefox gets into this state, can you "force" repaints by resizing the window or by focusing / unfocusing windows?

No, the window becomes completely unresponsive. I'm not sure if it is an infinite hang. I waited out 10 minutes and decided to close it.

Comment 4

[Marc Leclair [:mleclair]]

(In reply to Stephen A Pohl [:spohl] from comment #1)

The attached stack shows a hang rather than a crash. Would you be able to collect a performance profile and upload it? I'm cc'ing Markus in case he has additional recommendations about the specific profile to collect.

Link to profiler: https://profiler.firefox.com/
Docs for the built-in profiler: https://profiler.firefox.com/docs/#/

I could try to gather the profile. My inspector wasn't working so I couldn't access the profiler there. If I can reproduce again, I can try to get that profile

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Florian Quèze [:florian]]

It happens for me every once in a while when I get the machine out of sleep in the morning that the Firefox window doesn't refresh itself. I know the Firefox process is still responsive as the mouse cursor updates when I move it around. If I resize the window, I get a frame painted but that doesn't restart vsync. It usually fixes itself after a few seconds (but long enough to be really annoying).

I got a profile of it this morning: https://share.firefox.dev/3PFrFUK
The main thread only has RefreshDriverTick markers when I resized the window, until everything unblocks at around 7s on the timeline (the profiler ran out of buffer space, but it took more than 7s for things to unblock).

Comment 7

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Something similar to this happens to me currently too. Florian mentioned that it fixes itself after a few seconds but it just infinitely happens to me and doesn't fix itself at all.
It only renders when I either switch windows with cmd+tab or when I resize. When I type something on the address bar, it registers the key strokes and renders them all together when I do a resize.

I managed to get a profile while it was still doing this problem: https://share.firefox.dev/3CrMjSQ
I started the profiler, then wrote some random letters and then pressed cmd+tab so it can render. you can see from the screenshots that it doesn't render for a long while and then renders all the letters when I switch to another application.