1749440 - Add a Insert method taking a mozilla::Span parameter for nsTSubstring

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

nsTSubstring::Append can take mozilla::Span argument [1]. It would be nice to have Insert taking mozilla::Span as well.

For example: to insert a span at the beginning of a string, we can use [2] on currently m-c and write

Span s(...)
nsString str(...)
str.insert(s.Elements(), 0, s.Length());

However, it's more convenient to have insert accept Span, similar to the one taking a string [3].

Span s(...)
nsString str(...)
str.insert(s, 0);

[1] https://searchfox.org/mozilla-central/rev/618f9970972adc5a21194d39d690ec0865f26024/xpcom/string/nsTSubstring.h#946-962
[2] https://searchfox.org/mozilla-central/rev/618f9970972adc5a21194d39d690ec0865f26024/xpcom/string/nsTSubstring.h#727-730
[3] https://searchfox.org/mozilla-central/rev/618f9970972adc5a21194d39d690ec0865f26024/xpcom/string/nsTSubstring.h#738-740

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1749440 - Add nsTSubstring::Insert() that takes a mozilla::Span parameter.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/066e981f1e8e
Add nsTSubstring::Insert() that takes a mozilla::Span parameter. r=xpcom-reviewers,nika

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/066e981f1e8e