1749477 - Array.prototype.groupBy should return an object with a null prototype

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tom S]

The spec steps and JS implementation don't seem to match:

/* Step 7. Let obj be ! OrdinaryObjectCreate(null). */
var object = {};

I think this should be std_Object_create(null) or maybe {__proto__: null}, but I don't remember if that works.

Comment 1

[Yulia Startsev [:yulia]]

Ah, this is my oversight. I think Rolf and Sigurd are on to other things, but I will check with them and if they don't have time I will take this.

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1749477 - change array groupby to create a null prototype object; r=evilpie

Depends on D137279

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1749477 - new array methods should be unscopable; r=evilpie

Depends on D137280

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faf29999cc23
change array groupby to create a null prototype object; r=evilpie
https://hg.mozilla.org/integration/autoland/rev/d63e96d23111
new array methods should be unscopable; r=evilpie

Comment 5

[Cristian Tuns]

Backed out for causing reftest failures on unscopables.js

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | js/src/tests/non262/Array/unscopables.js | Unknown file:///builds/worker/workspace/build/tests/jsreftest/tests/js/src/tests/non262/shell.js:188: Error: Assertion failed: got "values", expected "includes" at _[10] item 1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a3f29f8f8dd
change array groupby to create a null prototype object; r=evilpie
https://hg.mozilla.org/integration/autoland/rev/0129cf4c1485
new array methods should be unscopable; r=evilpie

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6a3f29f8f8dd
https://hg.mozilla.org/mozilla-central/rev/0129cf4c1485