1749496 - Permafailing /test_xrayToJS.xhtml | A property on the Array prototype has changed! You need a security audit from an XPConnect peer when Gecko 98 merges to Beta on 2022-02-07

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Natalia Csoregi [:nataliaCs]]

• Central-as-beta
• How to run these simulations
• Failure log

[task 2022-01-11T12:43:54.799Z] 12:43:54     INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | Message correct: Error: Not allowed to define accessor property on [Object] or [Array] XrayWrapper 
[task 2022-01-11T12:43:54.799Z] 12:43:54     INFO - Buffered messages finished
[task 2022-01-11T12:43:54.803Z] 12:43:54     INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | A property on the Array prototype has changed! You need a security audit from an XPConnect peer - got "[\"at\", \"concat\", \"constructor\", \"copyWithin\", \"entries\", \"every\", \"fill\", \"filter\", \"find\", \"findIndex\", \"flat\", \"flatMap\", \"forEach\", \"includes\", \"indexOf\", \"join\", \"keys\", \"lastIndexOf\", \"length\", \"map\", \"pop\", \"push\", \"reduce\", \"reduceRight\", \"reverse\", \"shift\", \"slice\", \"some\", \"sort\", \"splice\", \"toLocaleString\", \"toSource\", \"toString\", \"unshift\", \"values\"]", expected "[\"at\", \"concat\", \"constructor\", \"copyWithin\", \"entries\", \"every\", \"fill\", \"filter\", \"find\", \"findIndex\", \"flat\", \"flatMap\", \"forEach\", \"groupBy\", \"groupByToMap\", \"includes\", \"indexOf\", \"join\", \"keys\", \"lastIndexOf\", \"length\", \"map\", \"pop\", \"push\", \"reduce\", \"reduceRight\", \"reverse\", \"shift\", \"slice\", \"some\", \"sort\", \"splice\", \"toLocaleString\", \"toSource\", \"toString\", \"unshift\", \"values\"]"
[task 2022-01-11T12:43:54.803Z] 12:43:54     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2022-01-11T12:43:54.803Z] 12:43:54     INFO - testXray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:440:7
[task 2022-01-11T12:43:54.803Z] 12:43:54     INFO - testArray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:626:13
[task 2022-01-11T12:43:54.803Z] 12:43:54     INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:163:5
[task 2022-01-11T12:43:54.803Z] 12:43:54     INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:1:1
[task 2022-01-11T12:43:54.803Z] 12:43:54     INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | A symbol-keyed property on the Array prototype has been changed! You need a security audit from an XPConnect peer 

Rolf, could you take a look at this?
Thank you.

Comment 1

[Yulia Startsev [:yulia]]

I will take this

Comment 2

[Yulia Startsev [:yulia]]

Simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7740c197c09d254d041235ef05f7ca0ca93daac

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1749496 - Add groupby and groupbytomap to xrayToJS only in nightly build

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1864277e3aac
Add groupby and groupbytomap to xrayToJS only in nightly build r=xpcom-reviewers,nika

Comment 5

[Yulia Startsev [:yulia]]

Does this affect 97? Do we need to uplift for the 97 beta?

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1739648 landed in 98 - no uplift needed.

Comment 7

[Cristian Tuns]

The patch seems to be working on today's beta sim: https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=645918b0632a5738997e5bf9c381b9eeee7cccae&group_state=expanded

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1864277e3aac

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

The patch was verified fixed on today's beta sim : https://treeherder.mozilla.org/jobs?repo=try&resultStatus=usercancel%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=14d55f9b392fc4f50967ea04b502d4424ba3ff59

Comment 10

[Intermittent Failures Robot]

3 failures in 3060 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform and build breakdown:

• windows10-32-2004-shippable-qr: 1
  • opt: 1
• windows10-64-2004-shippable-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1749496&startday=2022-01-10&endday=2022-01-16&tree=all