1749575 - Write tests for Document.getWireframe

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Mike Conley (:mconley) (:⚙️)]

We landed an experimental mechanism for getting low-fidelity wireframes of documents. We should write some tests for that mechanism.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1749575 - Add some tests for document.getWireframe. r?emilio!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey emilio, just starting to lay the groundwork for tests for the wireframe stuff. I'm starting with testing document.getWireframe directly. Does what I have so far match your expectations for a test for this thing? Or is there a better way you think I could approach it?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah, that approach seems reasonable. I'd factor the test into something like:

const kTests = [
  {
    html: `...`,
    wireframe: { ... },
  },
];

or so, like this test so that it's easy to add new tests without having to reimplement the tricky bits, but other than that it looks great :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1749575 - Add tests for nsISHEntry.wireframe capturing. r?emilio!

Depends on D140887

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06fc1c14947c
Add some tests for document.getWireframe. r=emilio
https://hg.mozilla.org/integration/autoland/rev/742ab2e2ac0f
Add tests for nsISHEntry.wireframe capturing. r=emilio

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/06fc1c14947c
https://hg.mozilla.org/mozilla-central/rev/742ab2e2ac0f