1749590 - Setting the value and defaultValue of a range input is a lot slower in Firefox than Chrome/Safari

Status: RESOLVED FIXED

(Core :: DOM: Forms, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The requestAnimationFrame callback on the attached test case takes about 400+ ms in Firefox vs ~10ms in Chrome. All of the time in Firefox is being spent in ICU.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: test.html

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This extra work is showing up noticeably in profiles when sliding the volume slider on twitch (see bug 1749365)

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Here's a profile of Firefox: https://share.firefox.dev/3zN8q4r

Comment 4

[Emilio Cobos Álvarez [:emilio]]

There's no reason the value of <input type=range> should use ICU. <input type=number> needs to accept possibly-localized user input, but that's not true of range. I can fix when I'm back from PTO if there's nobody who can take it earlier.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1749590 - Don't do localization shenanigans for <input type=range>. r=smaug,edgar

It should never need to deal with a localized value, unlike
<input type=number>.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Actually it's even more trivial than I thought.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7384180a6da7
Don't do localization shenanigans for <input type=range>. r=edgar

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7384180a6da7

Comment 9

[Jeff Muizelaar [:jrmuizel]]

I confirmed that this is dramatically better.