Closed Bug 1749641 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32335 - Revert "Limit text directives to text/html"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox98 fixed)

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32335 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32335
Details from upstream follow.

Maggie Cai <mxcai@chromium.org> wrote:

Revert "Limit text directives to text/html"

This reverts commit 1da0d0530ca2e50e0b00fd3c9840734983f82ca8.

Reason for revert: This CL is likely the culprit of the build failiure on Builder WebKit Linux ASAN
starting from https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/31918 and

Original change's description:

Limit text directives to text/html

Text directives shouldn't be applied on non-HTML documents like js or
xml files which could include sensitive application tokens.

This CL prevents invoking a text directive unless the Document's
contentType is "text/html".

Bug: 1270469
Change-Id: I7b478150b443ceb4ab71487ec3b2ef5ae1ed6f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3373605
Reviewed-by: Robert Flack \<flackr@chromium.org>
Commit-Queue: David Bokan \<bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#957724}

Bug: 1270469
Change-Id: Ic7dad2f678837fbe1a9ef16178660952724dccb8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/3382019
WPT-Export-Revision: 36b76e0b3a51cc05d675221a686ee5795451ce7f

PR 32335 applied with additional changes from upstream: d2b4abc05efad05dfa37d67500c40baa1be86311
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.