Open
Bug 1749687
Opened 2 years ago
Updated 2 years ago
Handle child processes better in GeckoProfiler gtests
Categories
(Core :: Gecko Profiler, task, P3)
Core
Gecko Profiler
Tracking
()
NEW
People
(Reporter: mozbugz, Unassigned)
References
Details
As found in bug 1749606, the GeckoProfiler.* gtests actually start/stop the profiler in any child process that may be present at the time!
However, we don't do anything to really tests the profiler running in child processes, so it's wasting resources there. Though it may have the side benefit of sometimes revealing issues during development, like in bug 1749606.
This could even explain some intermittent bugs, because we don't wait for the profiler to stop in child processes before restarting it in another test.
So we may want to consider:
- Having a way for most gtests to only start/stop the profiler in the current process. This could probably be done with the "pid:<current process pid>" filter.
- Adding some tests that properly exercise the profiler in child processes. But this may overlap with existing xpcshell/mochitests?
You need to log in
before you can comment on or make changes to this bug.
Description
•