1749725 - Verify if WorkerRunnable::Cancel can just assert against re-entrance

Status: RESOLVED WORKSFORME

(Core :: DOM: Workers, task)

Description

[Jens Stutte [:jstutte]]

In bug 1741182 we updated all WorkerRunnable::Cancel overrides for correct error handling. During review, :smaug asked if we could instead just assert this.

Here is a try run with this assert.

Even if this is green, it is not immediately clear, if Cancel can be called (or triggered to be called) more than once through JS and having appropriate error handling is actually needed here.

Comment 1

[Jens Stutte [:jstutte]]

I assume this is still relevant after your runnable refactorings?

Comment 2

[Eden Chuang[:edenchuang]]

Will double check if we can replace checking with assertion.

Comment 3

[Eden Chuang[:edenchuang]]

We don't need assertion since WorkerRunnable::Cancel() no need to be called in inherited Cancel() implementation.