Add a commit message hook that prevents landing WIP commits
Categories
(Developer Services :: Mercurial: hg.mozilla.org, task)
Tracking
(Not tracked)
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(1 file)
I have been noticed a few recent landings starting with "WIP:".
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by cosheehan@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/354aaa43211a
Don't allow commit messages starting with WIP. r=sheehan
Pushed by cosheehan@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/afba7cb37729 hghooks: add tests for wip commit message checker
|
|
Assignee | |
Comment 4•2 years ago
|
||
This might not be working? https://hg.mozilla.org/integration/autoland/rev/8e42c80a077bb156555aeef544e147513d039c9c
|
||
Comment 5•2 years ago
|
||
I have to deploy it, which I am about to do now. :)
Sorry for the holdup.
|
|
Assignee | |
Comment 6•2 years ago
|
||
Oh, don't worry. I had wrongly assumed that after landing the commit it would automatically apply.
|
|
||
Comment 7•2 years ago
•
|
||
Should be deployed now, let me know if you see any other issues pop up.
I added a check to Lando as well so users should see a warning about the erroneous WIP before they try and land, and if they do so anyways, your hook check will block the push. :)
Edit: once the Lando patch is deployed to prod*
Description
•