1749770 - [traceback] TypeError: post() got an unexpected argument ActiveExperiment

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sentry: https://sentry.prod.mozaws.net/operations/socorro-new-prod/issues/16920766/

Traceback:

TypeError: post() got an unexpected keyword argument 'ActiveExperiment'
  File "django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "crashstats/api/views.py", line 121, in _clear_empty_session
    ret = fun(request, *args, **kwargs)
  File "crashstats/api/views.py", line 150, in _no_csrf
    ret = fun(request, *args, **kwargs)
  File "ratelimit/decorators.py", line 24, in _wrapped
    return fn(request, *args, **kw)
  File "crashstats/crashstats/decorators.py", line 110, in inner
    response = view(request, *args, **kwargs)
  File "crashstats/crashstats/utils.py", line 244, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/api/views.py", line 255, in model_wrapper
    result = function(**form.cleaned_data)

Looks like someone is fuzzing SuperSearch and kicking this up. Need to look at the HTTP request and then go from there.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm not sure what's going on here because there are like 47 levels of indirection. I think the next step is to try to reproduce it locally and then see what happens. Making it a P3 to look at some day.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

There are two issues.

For some of the fuzzing things we're seeing, they're hitting API endpoints that have a GET, but no POST/PUT/DELETE and the default SocorroCommon implements all those methods with default functions for some reason. So we need to go through and set them to None.

The other fuzzing things we're seeing, it's dying because the form allows for other params, but the function doesn't. If we add a **kwargs to the other api functions, then that'll slurp up the fake querystring and data params and we can ignore them.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Updated Sentry issue: https://sentry.io/organizations/mozilla/issues/3570433598/?query=is%3Aunresolved

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6185: bug 1749770: fix API endpoints to be more resilient

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6185: "bug 1749770: fix API endpoints to be more resilient" in a3394e9.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this in bug #1790053. I marked the related Sentry errors as resolved. If another one pops up, I'll look into it, but for now I think this is FIXED.