[Windows 10] [Dark Theme] [Light Theme] My OS is in dark mode but Thunderbird in light mode: Details field of calendar appointments has black background and black text color
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(thunderbird_esr91? fixed, thunderbird97 unaffected, thunderbird98 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr91 | ? | fixed |
| thunderbird97 | --- | unaffected |
| thunderbird98 | --- | unaffected |
People
(Reporter: mozilla, Assigned: Paenglab)
Details
Attachments
(3 files, 1 obsolete file)
|
40.28 KB,
image/jpeg
|
Details | |
|
819 bytes,
patch
|
aleca
:
review+
wsmwk
:
approval-comm-esr91+
|
Details | Diff | Splinter Review |
|
5.43 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
black-bg-2.jpg
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Firefox/95.0
Steps to reproduce:
I have activated windows 10 dark mode for apps. I have activated Thunderbird Light Theme (and deactivated dark theme and system theme).
Actual results:
All my appointments that I open in detail have a black background and a black text color in the big remark area. So I cannot read any remark. (This is the same in edit mode and in read only mode of the appointment item.)
Expected results:
Remark field should also have white background as all the other small fields do have, indipendently from he OS theme.
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
This happens only on 91.
It seems that inside the iframe the <html> doesn't get the background-color of the theme. My patch is a hack to get it working with the light TB theme when the dark system theme is active.
|
|
Assignee | |
Updated•3 years ago
|
Do I have to wait for a later version or can I use this patch in any way at this time by myself? :)
|
|
Assignee | |
Comment 3•3 years ago
|
||
You have to wait.
|
||
Comment 4•3 years ago
|
||
|
|
Assignee | |
Comment 5•3 years ago
|
||
Comment on attachment 9258747 [details] [diff] [review]
1749781-event-description-background.patch
[Approval Request Comment]
User impact if declined: unreadable description in events with dark system and light TB theme.
Testing completed (on c-c, etc.): ESR-91 only bug
Risk to taking this patch (and alternatives if risky): should be low.
|
|
Assignee | |
Comment 6•3 years ago
|
||
Closing bug because it lands only on ESR.
|
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9258747 [details] [diff] [review]
1749781-event-description-background.patch
[Triage Comment]
Approved for esr91
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 91.5.1:
https://hg.mozilla.org/releases/comm-esr91/rev/46a4af6b6297
|
|
||
Updated•3 years ago
|
|
|
||
Comment 9•3 years ago
|
||
Reopened due to test failures and the fact that this change is affecting extensions that style the compose window.
https://treeherder.mozilla.org/jobs?repo=comm-esr91&selectedTaskRun=JU4eSuy_QPWZfaplDVhMTQ.0
|
|
||
Comment 10•3 years ago
|
||
I fixed the tests and the regression by creating a dedicated event editor CSS.
This is only necessary for 91 as it seems that editor doesn't inherit the correct background color, not sure why since the compose editor does. Probably an old toolkit issue due to the calendar event dialog having nested iframes.
Asking for a review to Richard to be sure the dialog looks good.
|
|
Assignee | |
Comment 11•3 years ago
|
||
Comment on attachment 9262247 [details] [diff] [review]
91-event-editor.diff
This doesn't work for me. I get following error: Security Error: Content at moz-nullprincipal:{ed8d3c8d-a694-4f0c-a0dd-12e63a94e25b} may not load or link to chrome://calendar/content/calendar-event-editor.css..
Also the summary dialog needs the same treatment.
|
|
Assignee | |
Comment 12•3 years ago
|
||
Moving calendar-event-editor.css to the same place as EditorContent.css makes it working.
|
|
||
Comment 13•3 years ago
|
||
|
|
||
Comment 14•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 91.6.0:
https://hg.mozilla.org/releases/comm-esr91/rev/676bfbddd4b3
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 15•3 years ago
|
||
Comment on attachment 9262412 [details] [diff] [review]
91-event-editor.diff
Thanks!
Description
•