1749828 - Support cached grouppos in windows and xpcom

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Eitan Isaacson [:eeejay]]

I forgot to change the platform bindings to work with the new Accessible methods.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1749828 - Use Accessible::GroupPosition in xpcom, windows and mac. r?Jamie

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0082e8e7edd9
Use Accessible::GroupPosition in xpcom, windows and mac. r=Jamie

Comment 3

[Iulian Moraru]

Backed out (bug 1748749, bug 1743967, bug 1749828) for causing build bustages on RotorRules.mm.

Push with failures

Failure log

Backout link

[task 2022-01-28T22:28:05.335Z] 22:28:05     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/mac'
[task 2022-01-28T22:28:05.335Z] 22:28:05     INFO -  accessible/mac/Unified_mm_accessible_mac0.o
[task 2022-01-28T22:28:05.338Z] 22:28:05     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/MacOSX10.12.sdk -mmacosx-version-min=10.12 -stdlib=libc++ -std=gnu++17 --target=x86_64-apple-darwin -o Unified_mm_accessible_mac0.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/accessible/mac -I/builds/worker/workspace/obj-build/accessible/mac -I/builds/worker/checkouts/gecko/accessible/base -I/builds/worker/checkouts/gecko/accessible/generic -I/builds/worker/checkouts/gecko/accessible/html -I/builds/worker/checkouts/gecko/accessible/ipc -I/builds/worker/checkouts/gecko/accessible/ipc/other -I/builds/worker/checkouts/gecko/accessible/xul -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/widget -I/builds/worker/checkouts/gecko/widget/cocoa -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing  -MD -MP -MF .deps/Unified_mm_accessible_mac0.o.pp   -x objective-c++ -fobjc-exceptions   Unified_mm_accessible_mac0.mm
[task 2022-01-28T22:28:05.338Z] 22:28:05     INFO -  In file included from Unified_mm_accessible_mac0.mm:119:
[task 2022-01-28T22:28:05.339Z] 22:28:05    ERROR -  /builds/worker/checkouts/gecko/accessible/mac/RotorRules.mm:317:14: error: unused variable 'groupPos' [-Werror,-Wunused-variable]
[task 2022-01-28T22:28:05.339Z] 22:28:05     INFO -      GroupPos groupPos = aAcc->GroupPosition();
[task 2022-01-28T22:28:05.339Z] 22:28:05     INFO -               ^
[task 2022-01-28T22:28:05.339Z] 22:28:05     INFO -  1 error generated.
[task 2022-01-28T22:28:05.339Z] 22:28:05    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:668: Unified_mm_accessible_mac0.o] Error 1
[task 2022-01-28T22:28:05.340Z] 22:28:05     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/mac'
[task 2022-01-28T22:28:05.340Z] 22:28:05    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: accessible/mac/target-objects] Error 2
[task 2022-01-28T22:28:05.340Z] 22:28:05     INFO -  gmake[3]: *** Waiting for unfinished jobs....
[task 2022-01-28T22:28:05.340Z] 22:28:05     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/icu/i18n'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afda8c72ba29
Use Accessible::GroupPosition in xpcom, windows and mac. r=Jamie

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing several types of bc failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&fromchange=afda8c72ba29bcc14c25d9f448db24e8639d5093&tochange=78000a724660f15f54e12cc0609200ace99a4512&selectedTaskRun=BCUvRrprSIe7EX8tQFUj8w.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=366256095&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=366253153&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=366258041&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/2e89ef6864e854344f755ad2529e8be23efa12a9

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2642c279e93
Use Accessible::GroupPosition in xpcom, windows and mac. r=Jamie CLOSED TREE

Comment 7

[Cosmin Sabou [:CosminS]]

The failures in comment 5 may be caused by the changes in Bug 1750070 https://hg.mozilla.org/integration/autoland/rev/f341a77792975d571bc48ebaba38095e7b9ac967 so I relanded this to see if they still happen.

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2642c279e93