1749856 - [Automated review] False positive build error on gfx/thebes/ThebesRLBox.h

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

In https://phabricator.services.mozilla.com/D135639, clang-diagnostic-error reports "Build Error" on gfx/thebes/ThebesRLBox.h:17. It seems the diagnostic environment has trouble finding rlbox.wasm.h.

https://searchfox.org/mozilla-central/rev/5ce782034b736293836a2850ab698e149ca04657/gfx/thebes/ThebesRLBox.h#17

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Andi [:andi]]

This is very strange because the try stask seems to be green: https://treeherder.mozilla.org/jobs?repo=try&revision=2937129dd330e39935fa88ee05a93bb288cddbb5&selectedTaskRun=CcuQBn-sQi6wOGkD_LriZQ.0
Unfortunately I can no longer access it because it expired but if this will re-occur please open this bug.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1749856 - Use GeneratedFile for rlbox.wasm.c.

This moves the creation of both rlbox.wasm.c and rlbox.wasm.h to
pre-compile, which allows static-analysis to create both files (but more
importantly the .h) without also compiling rlbox.wasm.c, which takes
forever.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ab6f64a0e0f
Use GeneratedFile for rlbox.wasm.c. r=firefox-build-system-reviewers,andi

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1ab6f64a0e0f

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 9337808 [details]
Bug 1749856 - Use GeneratedFile for rlbox.wasm.c.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Required for bug 1848908.
• User impact if declined: See above
• Fix Landed on Version: 116
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively straightforward build system only change.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9337808 [details]
Bug 1749856 - Use GeneratedFile for rlbox.wasm.c.

Approved for 115.3esr.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/24b06fb9d4c6