1749870 - [wpt-sync] Sync PR 32357 - Fix issue with VideoFrameMetadata merging for bool=true fields.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32357 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32357
Details from upstream follow.

Dale Curtis <[e-mail]> wrote:

Fix issue with VideoFrameMetadata merging for bool=true fields.

The code was written assuming that if (metadata.value) was false,
it shouldn't be merged. This is fine for optional fields, but not
bool fields.

Specifically in this bug, texture_origin_is_top_left defaults to
true, but is set to false when a canvas backed VideoFrame is made.
The old path would fail to copy the false value over.

This fixes the merge process and adds a test for this case. It also
adds a missing 'dcomp_surface' to the merge process.

R=tguilbert

Fixed: 1277865
Change-Id: I96f7a8032327adaa150ffe7412883bcfb051f71e

Reviewed-on: https://chromium-review.googlesource.com/3385357
WPT-Export-Revision: b5babf419ce2dda7e0ce7bfde1f4f2ed61f650cd

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3c9664b6056411b5813ae8e6445d16d8b5834f6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
FAIL: 6

Chrome

OK : 1
PASS: 5
FAIL: 1

Safari

OK : 1
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/videoFrame-canvasImageSource.html
<video> and VideoFrame constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
CSSImageValue constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Image element constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
SVGImageElement constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Canvas element constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Copy of canvas element constructed VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5d817ab5b03b
https://hg.mozilla.org/mozilla-central/rev/12b770f7dd2f