1749949 - Wrong day heading lengths used when rotating the week view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Steps to reproduce

There are two problems, with a common source (not changing the heading lengths at the right time).

Case 1

1. Go to the week view, and make sure it is non-rotated.
2. Shrink the window horizontally until the day headings use their short form (e.g. "Tue" rather than "Tuesday").
3. Rotate the view.
4. Rotate back.

Case 2

1. Go to the week view, and make sure it is non-rotated.
2. Grow the window horizontally until the day headings are in their long form.
3. Rotate the view.

Result

In case 1, the day headings are in their overflowing long forms.

In case 2, the view shows slightly more than the expected number of visible hours.

Expect

In case 1, they should be in their short form.

In case 2, the view should show the exact number of visible hours (the problem is that the pixels per minute is calculated when the headings are in their long form, but they are then switched to their short form).

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1749949 - Adjust the week view in the correct order when rotating. r=darktrojan

We now make sure to adjust the headings and remove any fixed sizing or positioning (which depends on the rotation) before calculating the pixelsPerMinute.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8e84c25d6aea
Adjust the week view in the correct order when rotating. r=darktrojan