Closed Bug 1750102 Opened 2 years ago Closed 2 years ago

Context menus can't be closed by clicking again

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox96 --- wontfix
firefox97 --- wontfix
firefox98 --- wontfix
firefox99 --- wontfix
firefox100 --- wontfix
firefox101 --- wontfix
firefox102 --- wontfix
firefox103 --- fixed

People

(Reporter: streetwalkermc, Assigned: emilio)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Due to the negative margin introduced by bug 1738265, that actual window for context menus spawns under the mouse cursor, so clicking again will do nothing. Left- or right-clicking again used to close the menu, now I need to move the mouse first.

Considering the shadows are a form of CSD, Firefox should probably be setting the input region properly on popup surfaces. I'm not sure how that should be handled on X11.

Firefox Nightly, sway 1.6.1, Arch Linux.

Regressed by: 1738265
Has Regression Range: --- → yes

Set release status flags based on info from the regressing bug 1738265

Actually the rollup code is kinda hand-rolled IIUC, so tweaking is_mouse_in_window might work for X11 too... The callers should have the right nsWindow, which should have access to the margins, presumably.

This was an existing bug with a bunch of other popups before the regressing bug, like the hamburger menu and so on, though perhaps for the context menu it is more important since that opens under the mouse to begin with.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 1771950

Recompute the input region when resizing the widget and so on, and use
it to check for rollups.

Depends on D148211

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8b026cff732
Add an input-region-margin to widgets, and implement it on Linux. r=stransky
Blocks: 1772507

Backed out changeset c8b026cff732 (Bug 1750102) for causing bc failures on browser_test_autoscrolling_in_extension_popup_window.js.
Backout link
Push with failures
Failure Log

Flags: needinfo?(emilio)

Backed out changeset d2838baf9655 (Bug 1750102) for causing bustages on nsStyleStruct.cpp by partially backing out 1750102.
Backout link
Push with failures
Failure Log

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3358dd331f4
Add an input-region-margin to widgets, and implement it on Linux. r=stransky
Flags: needinfo?(emilio)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
See Also: → 1844010
Regressions: 1866770
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: