Context menus can't be closed by clicking again
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
People
(Reporter: streetwalkermc, Assigned: emilio)
References
(Regressed 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Due to the negative margin introduced by bug 1738265, that actual window for context menus spawns under the mouse cursor, so clicking again will do nothing. Left- or right-clicking again used to close the menu, now I need to move the mouse first.
Considering the shadows are a form of CSD, Firefox should probably be setting the input region properly on popup surfaces. I'm not sure how that should be handled on X11.
Firefox Nightly, sway 1.6.1, Arch Linux.
Updated•2 years ago
|
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1738265
Assignee | ||
Comment 2•2 years ago
|
||
Actually the rollup code is kinda hand-rolled IIUC, so tweaking is_mouse_in_window might work for X11 too... The callers should have the right nsWindow
, which should have access to the margins, presumably.
This was an existing bug with a bunch of other popups before the regressing bug, like the hamburger menu and so on, though perhaps for the context menu it is more important since that opens under the mouse to begin with.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Recompute the input region when resizing the widget and so on, and use
it to check for rollups.
Depends on D148211
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8b026cff732 Add an input-region-margin to widgets, and implement it on Linux. r=stransky
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/d2838baf9655 Two minor style system fixups.
Comment 6•2 years ago
|
||
Backed out changeset c8b026cff732 (Bug 1750102) for causing bc failures on browser_test_autoscrolling_in_extension_popup_window.js.
Backout link
Push with failures
Failure Log
Comment 7•2 years ago
|
||
Backed out changeset d2838baf9655 (Bug 1750102) for causing bustages on nsStyleStruct.cpp by partially backing out 1750102.
Backout link
Push with failures
Failure Log
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3358dd331f4 Add an input-region-margin to widgets, and implement it on Linux. r=stransky
Assignee | ||
Updated•2 years ago
|
Comment 9•2 years ago
|
||
bugherder |
Comment 10•2 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Comment 11•2 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•2 years ago
|
Description
•